From 7185a16c56390dbad36fcc06921f8796d1e03fd9 Mon Sep 17 00:00:00 2001 From: Quinn Pham Date: Mon, 27 Apr 2026 17:33:54 +0000 Subject: [PATCH] Revert "Disable example plugins on Windows (#6281)" This reverts commit 006159c17520373e9e4b792bd561c58c3717a2c3. --- CMakeLists.txt | 9 --------- examples/plugins/CMakeLists.txt | 5 ----- test/Plugins/test-dialect-plugin.mlir | 2 +- test/Plugins/test-plugin.mlir | 2 +- test/lit.cfg.py | 4 ---- test/lit.site.cfg.py.in | 1 - 6 files changed, 2 insertions(+), 21 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index 2bad7cb84c..f17dcc2ad6 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -16,11 +16,6 @@ include(GNUInstallDirs) list(APPEND CMAKE_MODULE_PATH "${CMAKE_CURRENT_SOURCE_DIR}/cmake") -set(_triton_plugins_default ON) -if (WIN32) - set(_triton_plugins_default OFF) -endif() - # Options option(TRITON_BUILD_PYTHON_MODULE "Build Python Triton bindings" OFF) option(TRITON_BUILD_PROTON "Build the Triton Proton profiler" ON) @@ -45,10 +40,6 @@ set(TRITON_CUPTI_INCLUDE_PATH "" CACHE PATH "Path to CUPTI headers") set(TRITON_CUPTI_LIB_PATH "" CACHE PATH "Path to CUPTI libraries") set(TRITON_CUPTI_LIB_BLACKWELL_PATH "" CACHE PATH "Path to Blackwell CUPTI libraries") -if (WIN32 AND TRITON_ENABLE_PLUGINS) - message(FATAL_ERROR "TRITON_ENABLE_PLUGINS=ON is not supported on Windows.") -endif() - if(NOT TRITON_CACHE_PATH) message(FATAL_ERROR "TRITON_CACHE_PATH must be set or derivable from TRITON_HOME/HOME/USERPROFILE/HOMEPATH.") endif() diff --git a/examples/plugins/CMakeLists.txt b/examples/plugins/CMakeLists.txt index f9b151d28a..fe352dc0bd 100644 --- a/examples/plugins/CMakeLists.txt +++ b/examples/plugins/CMakeLists.txt @@ -1,8 +1,3 @@ -if (NOT TRITON_ENABLE_PLUGINS) - message(STATUS "TRITON_ENABLE_PLUGINS=OFF: skipping Triton example plugin libraries") - return() -endif() - set(LLVM_TARGET_DEFINITIONS Passes.td) mlir_tablegen(Passes.h.inc -gen-pass-decls -name Plugins) add_public_tablegen_target(TritonPluginsIncGen) diff --git a/test/Plugins/test-dialect-plugin.mlir b/test/Plugins/test-dialect-plugin.mlir index 6de06cf935..35ccbf4ef1 100644 --- a/test/Plugins/test-dialect-plugin.mlir +++ b/test/Plugins/test-dialect-plugin.mlir @@ -4,7 +4,7 @@ // RUN: -split-input-file --convert-plugin-gpu-to-llvm --convert-triton-gpu-to-llvm %s | \ // RUN: FileCheck %s -// REQUIRES: plugins, triton-ext-enabled +// REQUIRES: triton-ext-enabled // XFAIL: * #blocked0 = #ttg.blocked<{sizePerThread = [8], threadsPerWarp = [32], warpsPerCTA = [8], order = [0]}> diff --git a/test/Plugins/test-plugin.mlir b/test/Plugins/test-plugin.mlir index 1c395a5652..ec09469dc2 100644 --- a/test/Plugins/test-plugin.mlir +++ b/test/Plugins/test-plugin.mlir @@ -10,7 +10,7 @@ // RUN: triton-opt -split-input-file %s | FileCheck %s -allow-unused-prefixes --check-prefix=CHECK-BASE -// REQUIRES: plugins, triton-ext-enabled +// REQUIRES: triton-ext-enabled // XFAIL: * module attributes {"ttg.num-warps" = 4 : i32, "ttg.target" = "cuda:80"} { diff --git a/test/lit.cfg.py b/test/lit.cfg.py index a240363acf..1dfc0c5cf5 100644 --- a/test/lit.cfg.py +++ b/test/lit.cfg.py @@ -63,10 +63,6 @@ ToolSubst('%PYTHON', config.python_executable, unresolved='ignore'), ] -# Example plugins are not built if TRITON_ENABLE_PLUGINS is OFF. -if config.enable_plugins: - config.available_features.add("plugins") - # Static libraries are not built if TRITON_EXT_ENABLED is ON. if config.triton_ext_enabled: config.available_features.add("triton-ext-enabled") diff --git a/test/lit.site.cfg.py.in b/test/lit.site.cfg.py.in index ba1c2e2dfc..90e4ae71ef 100644 --- a/test/lit.site.cfg.py.in +++ b/test/lit.site.cfg.py.in @@ -13,7 +13,6 @@ config.llvm_exe_ext = "@EXEEXT@" config.lit_tools_dir = "@LLVM_LIT_TOOLS_DIR@" config.mlir_binary_dir = "@MLIR_BINARY_DIR@" config.python_executable = "@Python3_EXECUTABLE@" -config.enable_plugins = "@TRITON_ENABLE_PLUGINS@" config.enable_bindings_python = @MLIR_ENABLE_BINDINGS_PYTHON@ config.triton_ext_enabled = @TRITON_EXT_ENABLED@