Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Commit 99c77f7

Browse files
committed
Enable IN test, remove string-related queries.
1 parent 23af140 commit 99c77f7

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

omniscidb/QueryEngine/CgenState.cpp

+1-1
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ llvm::Value* CgenState::emitCall(const std::string& fname,
213213
const std::vector<llvm::Value*>& args) {
214214
// Get the function reference from the query module.
215215
auto func = module_->getFunction(fname);
216-
CHECK(func);
216+
CHECK(func) << "Unable to find function \"" << fname << "\" in the module.";
217217
// If the function called isn't external, clone the implementation from the runtime
218218
// module.
219219
maybeCloneFunctionRecursive(func, is_l0_module(module_));

omniscidb/Tests/IntelGPUEnablingTest.cpp

+7-4
Original file line numberDiff line numberDiff line change
@@ -787,19 +787,22 @@ TEST_F(BasicTest, TimeExtract) {
787787
}
788788

789789
TEST_F(BasicTest, In) {
790-
GTEST_SKIP();
791790
c("SELECT COUNT(*) FROM test WHERE x IN (7, 8);", g_dt);
792791
c("SELECT COUNT(*) FROM test WHERE x IN (9, 10);", g_dt);
793792
c("SELECT COUNT(*) FROM test WHERE z IN (101, 102);", g_dt);
794793
c("SELECT COUNT(*) FROM test WHERE z IN (201, 202);", g_dt);
794+
c("SELECT COUNT(*) FROM test WHERE x IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, "
795+
"14, 15, 16, 17, 18, 19, 20);",
796+
g_dt);
797+
}
798+
799+
TEST_F(BasicTest, InWithStrings) {
800+
GTEST_SKIP();
795801
c("SELECT COUNT(*) FROM test WHERE real_str IN ('real_foo', 'real_bar');", g_dt);
796802
c("SELECT COUNT(*) FROM test WHERE real_str IN ('real_foo', 'real_bar', 'real_baz', "
797803
"'foo');",
798804
g_dt);
799805
c("SELECT COUNT(*) FROM test WHERE str IN ('foo', 'bar', 'real_foo');", g_dt);
800-
c("SELECT COUNT(*) FROM test WHERE x IN (1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, "
801-
"14, 15, 16, 17, 18, 19, 20);",
802-
g_dt);
803806
}
804807

805808
int main(int argc, char* argv[]) {

0 commit comments

Comments
 (0)