Skip to content

Conversation

joremysh
Copy link
Contributor

@joremysh joremysh commented Oct 11, 2024

Because

  • consistency with other service client

This commit

  • rename app_service to app

@joremysh joremysh requested a review from heiruwu as a code owner October 11, 2024 06:36
Copy link

linear bot commented Oct 11, 2024

@joremysh
Copy link
Contributor Author

joremysh commented Oct 11, 2024

Note: app-backend grpc endpoint CreateApp returned the error below on prod

2024-10-10 17:06:07,736.736 WARNING  StatusCode.UNIMPLEMENTED
2024-10-10 17:06:07,737.737 WARNING  Received http2 header with status: 404

but ListApps works

  • check with app-backend developers @Yougigun

@Yougigun
Copy link

Note: app-backend grpc endpoint CreateApp returned the error below on prod

2024-10-10 17:06:07,736.736 WARNING  StatusCode.UNIMPLEMENTED
2024-10-10 17:06:07,737.737 WARNING  Received http2 header with status: 404

but ListApps works

  • check with app-backend developers @Yougigun

@joremysh it should be fixed in prod. please try again.

@joremysh
Copy link
Contributor Author

It's good now. Thanks

@joremysh joremysh merged commit f33aff3 into main Oct 12, 2024
17 checks passed
@joremysh joremysh deleted the jeremy/ins-6564-catchup-with-app-backend branch October 12, 2024 01:55
joremysh pushed a commit that referenced this pull request Oct 12, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.14.0](v0.13.0...v0.14.0)
(2024-10-12)


### Features

* **app:** update AppClient
([#221](#221))
([ccfc9fe](ccfc9fe))
* **client:** update proto and add AppClient
([#213](#213))
([6a73033](6a73033))


### Bug Fixes

* **app:** rename app_service to app
([#224](#224))
([f33aff3](f33aff3))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants