chore(mypy): fix make check errors

Author: pinglin

instill/clients/base.py

@@ -1,3 +1,5 @@
+"""Base client interface module."""
+
 from abc import ABC, abstractmethod
 from typing import Union
 
@@ -15,37 +17,42 @@ class Client(ABC):
     @property
     @abstractmethod
     def host(self):
-        pass
+        """Get the host address."""
 
     @host.setter
     @abstractmethod
-    def host(self):
-        pass
+    def host(self, value):
+        """Set the host address."""
 
     @property
     @abstractmethod
     def metadata(self):
-        pass
+        """Get the metadata."""
 
     @metadata.setter
     @abstractmethod
-    def metadata(self):
-        pass
+    def metadata(self, value):
+        """Set the metadata."""
 
     @abstractmethod
     def liveness(self):
+        """Check if the service is alive."""
         raise NotImplementedError
 
     @abstractmethod
     def readiness(self):
+        """Check if the service is ready to serve."""
         raise NotImplementedError
 
     @abstractmethod
     def is_serving(self):
+        """Check if the service is currently serving."""
         raise NotImplementedError
 
 
 class RequestFactory:
+    """Factory class for creating and sending gRPC requests."""
+
     def __init__(
         self,
         method: Union[grpc.UnaryUnaryMultiCallable, grpc.StreamUnaryMultiCallable],
@@ -57,13 +64,16 @@ def __init__(
         self.metadata = metadata
 
     def send_sync(self):
+        """Send a synchronous gRPC request."""
         return self.method(request=self.request, metadata=self.metadata)
 
     def send_stream(self):
+        """Send a streaming gRPC request."""
         return self.method(
             request_iterator=iter([self.request]),
             metadata=self.metadata,
         )
 
     async def send_async(self):
+        """Send an asynchronous gRPC request."""
         return await self.method(request=self.request, metadata=self.metadata)

instill/helpers/docker/Dockerfile.mlc

@@ -0,0 +1,69 @@
+# syntax=docker/dockerfile:1.7-labs
+ARG RAY_VERSION
+ARG PYTHON_VERSION
+ARG CUDA_SUFFIX
+ARG TARGET_ARCH_SUFFIX
+
+FROM rayproject/ray:${RAY_VERSION}-py${PYTHON_VERSION}${CUDA_SUFFIX}${TARGET_ARCH_SUFFIX}
+
+RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
+    --mount=type=cache,target=/var/lib/apt,sharing=locked \
+    sudo apt-get update && \
+    DEBIAN_FRONTEND=noninteractive sudo apt-get install -y tzdata curl vim cmake && \
+    sudo rm -rf /var/lib/apt/lists/*
+
+# Build mlc-llm from source
+RUN conda create -y -q -n mlc-venv -c conda-forge "cmake>=3.24" rust git python=${PYTHON_VERSION}
+RUN conda run -n mlc-venv bash -c " \
+    git clone --recursive https://github.com/mlc-ai/mlc-llm.git && \
+    cd mlc-llm/ && \
+    mkdir -p build && cd build && \    
+    echo '
+    set(TVM_SOURCE_DIR 3rdparty/tvm)\n \
+        set(CMAKE_BUILD_TYPE RelWithDebInfo)\n \
+        set(USE_CUDA OFF)\n \
+        set(USE_CUTLASS OFF)\n \
+        set(USE_CUBLAS OFF)\n \
+        set(USE_ROCM OFF)\n \
+        set(USE_VULKAN OFF)\n \
+        set(USE_METAL OFF)\n \
+        set(USE_OPENCL OFF)\n \
+        set(USE_OPENCL_ENABLE_HOST_PTR OFF)\n \
+        set(USE_FLASHINFER ON)' > config.cmake && \
+    cmake .. && cmake --build . --parallel $(nproc) && sudo make install"
+
+ARG SYSTEM_PACKAGES
+RUN --mount=type=cache,target=/var/cache/apt,sharing=locked \
+    --mount=type=cache,target=/var/lib/apt,sharing=locked \
+    sudo apt-get update && \
+    for package in ${SYSTEM_PACKAGES}; do \
+    DEBIAN_FRONTEND=noninteractive sudo apt-get install -y $package; \
+    done && \
+    sudo rm -rf /var/lib/apt/lists/*
+
+ARG PYTHON_PACKAGES
+RUN --mount=type=cache,target=/root/.cache/pip,sharing=locked \
+    for package in ${PYTHON_PACKAGES}; do \
+    pip install $package; \
+    done
+
+COPY --chown=ray:users . .
+
+ARG INSTILL_PYTHON_SDK_PROJECT_NAME
+ARG INSTILL_PYTHON_SDK_VERSION
+RUN --mount=type=cache,target=/root/.cache/pip,sharing=locked \
+    if [ ! -z "$INSTILL_PYTHON_SDK_PROJECT_NAME" ]; then \
+    pip install -e ${INSTILL_PYTHON_SDK_PROJECT_NAME}; \
+    elif [ -f instill_sdk-${INSTILL_PYTHON_SDK_VERSION}dev-py3-none-any.whl ]; then \
+    pip install instill_sdk-${INSTILL_PYTHON_SDK_VERSION}dev-py3-none-any.whl; \
+    else \
+    pip install instill-sdk==${INSTILL_PYTHON_SDK_VERSION}; \
+    fi;
+
+# The python-sdk is a local module that is not installed in the Ray worker environment.
+# Ray workers need to deserialize model configurations and deployment settings that were
+# created in the runtime environment. These objects may depend on this python-sdk.
+# Instead of installing the SDK in the Ray image, we copy
+# the entire SDK to /home/ray and set PYTHONPATH to allow dynamic importing.
+ARG PYTHONPATH_USER_DEFINED_PROTO
+ENV PYTHONPATH=${PYTHONPATH_USER_DEFINED_PROTO}

instill/resources/resource.py

@@ -1,3 +1,5 @@
+"""Base resource interface module."""
+
 # pylint: disable=no-member,wrong-import-position
 from abc import ABC, abstractmethod
 
@@ -12,19 +14,19 @@ class Resource(ABC):
     @property
     @abstractmethod
     def client(self):
-        pass
+        """Get the client instance."""
 
     @client.setter
     @abstractmethod
-    def client(self):
-        pass
+    def client(self, value):
+        """Set the client instance."""
 
     @property
     @abstractmethod
     def resource(self):
-        pass
+        """Get the resource instance."""
 
     @resource.setter
     @abstractmethod
-    def resource(self):
-        pass
+    def resource(self, value):
+        """Set the resource instance."""

pyproject.toml

@@ -40,7 +40,7 @@ protoc-gen-openapiv2 = "^0.0.1"
 pydantic = ">=1.10.13"
 python = ">3.9.1,<3.12"
 pyyaml = "^6.0.1"
-ray = "^2.44.1"
+ray = "2.47.0"
 requests = "^2.32.3"
 starlette = "^0.46.1"
 types-protobuf = "^4.24.0.1"