Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What features do you most want us to add ? #56

Open
ResearcherXman opened this issue Jan 24, 2024 · 29 comments
Open

What features do you most want us to add ? #56

ResearcherXman opened this issue Jan 24, 2024 · 29 comments

Comments

@ResearcherXman
Copy link
Member

ResearcherXman commented Jan 24, 2024

We are a small team and cannot handle all feature requests at once. Thus, please tell us what is your favorite feature you wanna us add. Comment under this post. Meanwhile, we encourage all kinds of PRs (fixing bugs, adding new features, etc.) from the community, if you want to take on a feature, please open a new issue naming "Support for xxx" and we will assign you. Thanks for your interests, love you all ❤️.

@ResearcherXman ResearcherXman pinned this issue Jan 24, 2024
@brunneis
Copy link

brunneis commented Jan 24, 2024

It would be great to support non-human faces. It would be great to add better support for non-human faces. Congrats for the great job!

Edit: it works on animals, but with many pictures I get a "Cannot find any input face image" error:

Traceback (most recent call last):
File "/root/.pyenv/versions/3.11.7/lib/python3.11/site-packages/cog/server/worker.py", line 217, in _predict
result = predict(**payload)
^^^^^^^^^^^^^^^^^^
File "/src/predict.py", line 173, in predict
face_info = sorted(
^^^^^^^
IndexError: list index out of range

@zewolf5
Copy link

zewolf5 commented Jan 24, 2024

Not sure if its already there, but multiple reference images? I could not find a way to select more than one image in the sample code provided. Topic #33 mentioned use of multiple reference images for better results.

Also is it possible to do some "adetailer magic" like upscaling the part of the image that contains the face, apply hires face-swap and then resize down again to the original image to get a detailed face when not covering the whole image?

I am still new to this, so ignore anything i have misunderstood.

@fofr
Copy link

fofr commented Jan 24, 2024

I'd love to see implementations of each of the examples in the paper.

@tgohblio
Copy link

tgohblio commented Jan 24, 2024

SD 1.5 support.

Opens up whole new possibilities with LORAs, AnimateDiff (as of today, it's SD 1.5 only since XL is in beta) and community-trained SD1.5 models.
Hint: this will drive more Github ⭐️

@nosiu
Copy link

nosiu commented Jan 24, 2024

Not sure if its already there, but multiple reference images? I could not find a way to select more than one image in the sample code provided. Topic #33 mentioned use of multiple reference images for better results.

I'm no expert but this should work
image = pipe( ... image_embeds=(face_emb1 + face_emb2 + face_emb3 + face_emb4)/4, ...)

@johndpope
Copy link
Contributor

johndpope commented Jan 24, 2024

Downstream has some nice illustrations- https://github.com/ZHO-ZHO-ZHO/ComfyUI-InstantID -
I played around with thie workflows - but couldn’t get results that I was after. It seems all the examples are based off text concatenation. - somehow interrogating image for words to add to prompt
Said another way - what I want is - given an image - can instantid make new images that look like it? Or is this not a suitable use case?
I realise t2i adapter colour will best fit here - but then how does instantid shine? Can you create something that looks like this?

IMG_9879

(this is the example in ComfyUI-InstantID)
Screenshot from 2024-01-25 06-58-10

@bent1e
Copy link

bent1e commented Jan 25, 2024

Adapt with IP Adapter to control the style of images by inputting ref instead of text prompt.

@johndpope
Copy link
Contributor

Thanks @bent1e - looks like the ref image has been updated. testing now
Screenshot from 2024-01-25 13-46-02

@marsplant
Copy link

Face swapper is wanted!
compare-b

@Kuvshin8
Copy link

Samplers? Sde/2M Karras or Euler A? I don't find any mentions about it

P.S. Thanks for your models

@brausesa
Copy link

Please make it possible for the local version to specify long tasks for generating images.... For example, so that I could specify one reference image of a face, plus specify several images of poses, plus, for example, select twenty different styles (prompts) and the number of variants (generations) for each style... and after pressing the "submit" button, I could go to sleep... And in the morning look ouput-folder with a hundred results :)

Thanks! You have made an incredible product!

@min-star
Copy link

Face swapper is wanted! compare-b

InstantID is not only swapper face,did you use it with other ways

@ameen-roayan
Copy link

a simple comfy ui implementation would be great.

@johndpope
Copy link
Contributor

Faceswapping is here - #89

@sbyebss
Copy link

sbyebss commented Feb 4, 2024

Although it's already mentioned here, I hope Multi-ID can be added

@cqflgl
Copy link

cqflgl commented Feb 8, 2024

项目很惊艳,非常感谢开源!
SD1.5版本的生态是最好的,如果能支持sd1.5,相信用户数和github星数都会上一个大台阶。

@cubiq
Copy link

cubiq commented Feb 11, 2024

Multi-ID is kinda possible already (in comfyui) even though a bit complicated at the moment, I'll see if I can find an easier way to do it #81 (comment)

@johndpope
Copy link
Contributor

Im interested to use this technology with music. there was some prior work done with riffusion - but lack luster model support - this could with the help of a new model - reopen box to create styles of music from spectrograms + prompts.

@JohnCarpenter2
Copy link

Provide the official prompts for generating images in different styles.

@MartialWrapperr
Copy link

Full body of the subject instead of portrait mode.

@andymacool
Copy link

Please support other base models : )

@ynie
Copy link

ynie commented Mar 6, 2024

Please train a model based on non-insight face weight

@JohnCarpenter2
Copy link

Please train a model based on non-insight face weight

I think it is a good idea. Otherwise, provide the quick method to fine-tune the pre-training weights of InstantID on other face recognition models.

@lilminthehoodieboi
Copy link

sd 1.5 support please

@elismasilva
Copy link

could be possible we add mask to a face without use face analysis, then you could use this with instant style.

@leafiy
Copy link

leafiy commented Jun 24, 2024

full body with small head please!!
emotion control please!!

@jordancoult
Copy link

I don't know if this is possible but, it would be insane.
InstantID for flux.

@appm111
Copy link

appm111 commented Aug 30, 2024

Add text support soon as possible 👍

@boco927
Copy link

boco927 commented Sep 4, 2024

really need multi-id function realized by code rather than comfyui because many machines doesn't support GUI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests