Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(amqp): publish span not transmitted when confirm cb is missing #745

Merged
merged 4 commits into from
Mar 28, 2023
Merged

fix(amqp): publish span not transmitted when confirm cb is missing #745

merged 4 commits into from
Mar 28, 2023

Conversation

kirrg001
Copy link
Contributor

No description provided.

@kirrg001 kirrg001 marked this pull request as ready for review March 28, 2023 10:29
@kirrg001 kirrg001 requested a review from a team March 28, 2023 10:36
basti1302
basti1302 approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@basti1302 basti1302 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 👍 👍

@kirrg001 kirrg001 merged commit 6dce419 into main Mar 28, 2023
@kirrg001 kirrg001 deleted the fix/amqp-confirm-cb-msg branch March 28, 2023 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@basti1302 basti1302 basti1302 approved these changes

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirrg001 @basti1302