fix: resolved issue in setLogger function with winston logger #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs INSTA-24448
aryamohanan
reviewed
Jan 17, 2025
| @@ -174,6 +174,10 @@ function setLoggerLevel(_logger, level) { | |||
| */ | |||
| function isPinoLogger(_logger) { | |||
There was a problem hiding this comment.
I’m still a bit concerned about this function. Would suggest revisiting this logic to ensure it accurately targets Pino logger without potentially matching other logging libraries that have similar properties.
abhilash-sivan
commented
Jan 17, 2025
| typeof _logger === 'object' && | ||
| typeof _logger.child === 'function' && | ||
| typeof _logger.level === 'string' && | ||
| typeof _logger.bindings === 'function' |
There was a problem hiding this comment.
The bindings method is unique to Pino .
There was a problem hiding this comment.
For me still its too generic. Other logging libraries might also implement similar methods. Otherwise, if you’re confident that no other logger implements it in the same way as Pino, then it could be fine for now.
aryamohanan
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs INSTA-24448
refs #1521