fix: resolved more logging objects structure #1510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilash-sivan
changed the title
aryamohanan
previously requested changes
Jan 14, 2025
abhilash-sivan
force-pushed
the
fix-log-object
branch
from
e28f2a0 to
dc2e79f
Compare
kirrg001
reviewed
Jan 14, 2025
| 'Received an invalid secrets configuration from the Instana host agent, attribute matcher is not a string: $s', | ||
| agentResponse.secrets.matcher | ||
| 'Received an invalid secrets configuration from the Instana host agent, attribute matcher is not a string: ' + | ||
| `${agentResponse.secrets.matcher}` |
There was a problem hiding this comment.
nitpik: Join all three modifications into one template literal.
kirrg001
reviewed
Jan 14, 2025
| '%s: %s', | ||
| packageJsonPath, | ||
| parseErr.message | ||
| `${packageJsonPath}: ${parseErr?.message}.` |
There was a problem hiding this comment.
nitpik: join the strings to one template literal
| '%s: %s.', | ||
| packageJsonPath, | ||
| err.message | ||
| `${packageJsonPath}: ${err?.message}.` |
There was a problem hiding this comment.
nitpik: join the strings to one template literal
| 'able to see details about this dependency within Instana.', | ||
| dependency, | ||
| parseErr.message | ||
| `Failed to identify version of ${dependency} dependency due to: ${parseErr?.message}.` + |
There was a problem hiding this comment.
nitpik: join the strings to one template literal
kirrg001
approved these changes
Jan 14, 2025
aryamohanan
reviewed
Jan 14, 2025
Co-authored-by: kirrg001 <[email protected]>
Co-authored-by: Arya <[email protected]>
Co-authored-by: Arya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes more log object structure and also added optional chaining for type safety