feat: added support for graphql-subscriptions v3 #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A major code change has affected our instrumentation. We might have to support both v2.0.0 and v3.0.0 separately. We can discuss it internally. https://github.com/apollographql/graphql-subscriptions/releases
|
abhilash-sivan
force-pushed
the
currency-bot-major-graphqlsubscriptions
branch
from
0c3c616 to
bc62393
Compare
abhilash-sivan
force-pushed
the
currency-bot-major-graphqlsubscriptions
branch
from
2c923a7 to
5338879
Compare
aryamohanan
reviewed
Nov 18, 2024
packages/collector/test/tracing/control_flow/pubsub_async_iterator/app_v2.js
Outdated
Show resolved
Hide resolved
packages/collector/test/tracing/control_flow/pubsub_async_iterator/app.js
Outdated
Show resolved
Hide resolved
|
commit suggestion
|
abhilash-sivan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tada!