Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolved issue with fetching agent key from ssm due to missing aws sdk #1402

Merged
merged 6 commits into from
Oct 28, 2024

Conversation

aryamohanan
Copy link
Contributor

@aryamohanan aryamohanan commented Oct 22, 2024

ref INSTA-17430

could not fetch instana key from ssm parameter store using "instanakey" because the aws sdk is not available. reason: cannot find module 'aws-sdk'.

Node.js 18.x is using AWS SDK v3. In our code, we are using AWS SDK v2. The problem is that, NodeJS 18.x runtime does not come with version 2 of the AWS SDK automatically packaged and ready to use. This is the reason we are getting the error for not being able to find aws-sdk.

@aryamohanan aryamohanan force-pushed the aws-sdk-ssm branch 2 times, most recently from eca638d to 88ba7d7 Compare October 24, 2024 06:21
@aryamohanan aryamohanan marked this pull request as ready for review October 24, 2024 06:35
@aryamohanan aryamohanan requested a review from a team as a code owner October 24, 2024 06:35
Copy link
Contributor

@abhilash-sivan abhilash-sivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aryamohanan aryamohanan merged commit 6329c66 into main Oct 28, 2024
1 check passed
@aryamohanan aryamohanan deleted the aws-sdk-ssm branch October 28, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants