fix: dropped support for disabling AWS SDK instrumentation in old syntax #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
changed the title
aryamohanan
commented
Oct 14, 2024
aryamohanan
force-pushed
the
v4-disable-aws-sdk
branch
from
c5f688b to
29211d2
Compare
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
…tax (#1383) BREAKING CHANGE: - Removed the ability to disable AWS SDK instrumentation using the old syntax disabledTracers: ['aws-sdk/v2/index']. - Migrate to the new syntax for disabling instrumentation: disabledTracers: ['aws-sdk/v2'].
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
…tax (#1383) BREAKING CHANGE: - Removed the ability to disable AWS SDK instrumentation using the old syntax disabledTracers: ['aws-sdk/v2/index']. - Migrate to the new syntax for disabling instrumentation: disabledTracers: ['aws-sdk/v2'].
aryamohanan
added a commit
that referenced
this pull request
Oct 18, 2024
…tax (#1383) BREAKING CHANGE: - Removed the ability to disable AWS SDK instrumentation using the old syntax disabledTracers: ['aws-sdk/v2/index']. - Migrate to the new syntax for disabling instrumentation: disabledTracers: ['aws-sdk/v2'].
aryamohanan
added a commit
that referenced
this pull request
Oct 21, 2024
…tax (#1383) BREAKING CHANGE: - Removed the ability to disable AWS SDK instrumentation using the old syntax disabledTracers: ['aws-sdk/v2/index']. - Migrate to the new syntax for disabling instrumentation: disabledTracers: ['aws-sdk/v2'].
aryamohanan
added a commit
that referenced
this pull request
Oct 22, 2024
…tax (#1383) BREAKING CHANGE: - Removed the ability to disable AWS SDK instrumentation using the old syntax disabledTracers: ['aws-sdk/v2/index']. - Migrate to the new syntax for disabling instrumentation: disabledTracers: ['aws-sdk/v2'].
aryamohanan
added a commit
that referenced
this pull request
Oct 23, 2024
…tax (#1383) BREAKING CHANGE: - Removed the ability to disable AWS SDK instrumentation using the old syntax disabledTracers: ['aws-sdk/v2/index']. - Migrate to the new syntax for disabling instrumentation: disabledTracers: ['aws-sdk/v2'].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test to verify that customers can disable AWS SDK v3 instrumentation using
disabledTracers: ['aws-sdk/v3'].This highlights a design issue in our earlier system.
Already documented in the public documenation
As part of the updates made in #866, we've introduced an instrumentationName in our AWS SDK instrumentation. This enhancement allowed us to disable the tracer effectively using the instrumentation name rather than relying on the instrumentation syntax.
BREAKING CHANGE: