-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: extended typescript support #1349
Conversation
- added typescript files - optimized exports
efea29b
to
c7d8794
Compare
For testing: See new test app. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Can we exclude compiled js files from the code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes we could do that. Lets do that after the release 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🤞
- added typescript .d.ts files - optimized exports
Problems:
Explanations
Typescript could not load our in-code typedefs. We had to provide types files.
We had no definitions for exported functions.
The PR is a beginning. We need to do much more. Raised a new ticket.
Works
Raised
https://jsw.ibm.com/browse/INSTA-15926
https://jsw.ibm.com/browse/INSTA-15926
Tasks