fix: deprecated kafka-avro #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhilash-sivan
approved these changes
Sep 19, 2024
aryamohanan
reviewed
Sep 23, 2024
| @@ -359,3 +364,10 @@ function findInstanaHeaderValues(instanaHeadersAsObject) { | |||
|
|
|||
| return { level, traceId, longTraceId, parentSpanId }; | |||
| } | |||
|
|
|||
| function logDeprecationKafkaAvroMessage() { | |||
There was a problem hiding this comment.
Suggestion for function name logKafkaAvroDeprecationWarning
There was a problem hiding this comment.
haha yeah you are right, but I am too lazy to change it now :D
|
Qs: Would it be possible to also remove the tests? It seems unnecessary to keep the skipped ones. |
I decided to keep them in case we need to test something. We do not have a rule when we remove the tests. |
aryamohanan
pushed a commit
that referenced
this pull request
Sep 25, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Sep 30, 2024
abhilash-sivan
pushed a commit
that referenced
this pull request
Sep 30, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Oct 7, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Oct 14, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Oct 14, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Oct 14, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Oct 14, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Oct 18, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Oct 21, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Oct 22, 2024
aryamohanan
pushed a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-1042
refs waldophotos/kafka-avro#120
Tests are already skipped.