Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Currency Bot] Bumped sqs-consumer from 9.1.0 to 10.1.0 #1134

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

kirrg001
Copy link
Contributor

Tada!

@kirrg001 kirrg001 requested a review from a team as a code owner April 28, 2024 02:12
@aryamohanan
Copy link
Contributor

They've updated their codebase to transition to ESM, highlighting it as a possible breaking change. However, they continue to support existing CommonJS configurations. You can find more details at bbc/sqs-consumer@v9.1.0...v10.0.0.
PR

@kirrg001 kirrg001 self-assigned this Apr 29, 2024
@kirrg001
Copy link
Contributor Author

@kirrg001
Copy link
Contributor Author

Seems fine for me as they build cjs & esm.

@aryamohanan aryamohanan force-pushed the currency-bot-major-sqsconsumer branch from f96a6f0 to 1e7a242 Compare April 29, 2024 07:21
@kirrg001
Copy link
Contributor Author

kirrg001 commented Apr 29, 2024

Built files are outputted into ./dist/esm, ./dist/cjs and ./dist/types

This is their new deployment dist structure.

In our instrumentation, we are using:

requireHook.onModuleLoad('sqs-consumer', instrument);

This is still working fine.

@kirrg001 kirrg001 force-pushed the currency-bot-major-sqsconsumer branch from 1e7a242 to f932d69 Compare April 29, 2024 09:04
@kirrg001 kirrg001 merged commit c929727 into main Apr 29, 2024
@kirrg001 kirrg001 deleted the currency-bot-major-sqsconsumer branch April 29, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants