Skip to content

Commit 65428b0

Browse files
committed
chore: updated code
1 parent 575654e commit 65428b0

File tree

3 files changed

+9
-2
lines changed

3 files changed

+9
-2
lines changed

packages/collector/src/announceCycle/unannounced.js

+3-2
Original file line numberDiff line numberDiff line change
@@ -225,9 +225,10 @@ function applySpanBatchingConfiguration(agentResponse) {
225225

226226
/**
227227
* - The agent configuration currently uses a pipe ('|') as a separator for endpoints.
228-
* - This function splits the string by both pipe ('|') and comma (',') to ensure compatibility.
228+
* - This function supports both ('|') and comma (',') to ensure future compatibility.
229229
* - Additionally, it supports the `string[]` format for backward compatibility,
230-
* as this was the previously used standard.
230+
* as this was the previously used standard. The final design decision is not yet completed.
231+
* https://github.ibm.com/instana/requests-for-discussion/pull/84
231232
*
232233
* @param {AgentAnnounceResponse} agentResponse
233234
*/

packages/collector/test/apps/agentStubControls.js

+2
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,8 @@ class AgentStubControls {
4343
env.KAFKA_TRACE_CORRELATION = opts.kafkaConfig.traceCorrelation.toString();
4444
}
4545
}
46+
// This is not the INSTANA_IGNORE_ENDPOINTS env. We use this "IGNORE_ENDPOINTS" env for the fake agent to
47+
// serve the ignore endpoints config to our tracer.
4648
if (opts.ignoreEndpoints) {
4749
env.IGNORE_ENDPOINTS = JSON.stringify(opts.ignoreEndpoints);
4850
}

packages/core/src/util/normalizeConfig.js

+4
Original file line numberDiff line numberDiff line change
@@ -723,5 +723,9 @@ function normalizeIgnoreEndpoints(config) {
723723
`Failed to parse INSTANA_IGNORE_ENDPOINTS: ${process.env.INSTANA_IGNORE_ENDPOINTS}. Error: ${error.message}`
724724
);
725725
}
726+
} else {
727+
return;
726728
}
729+
730+
logger.debug(`Ignore endpoints have been configured: ${JSON.stringify(config.tracing.ignoreEndpoints)}`);
727731
}

0 commit comments

Comments
 (0)