Remove faulty performance comment #76
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the comment about the performance part (see https://gist.github.com/substack/2790507#gistcomment-3100007). Instead, recommend to use `util.isDeepStrictEqual()`, if possible.
ljharb
reviewed
Dec 5, 2019
| Node's `assert.deepEqual() algorithm` as a standalone module. | ||
|
|
||
| This module is around [46 times faster](https://gist.github.com/substack/2790507#gistcomment-3099862) than wrapping `assert.deepEqual()` in a `try/catch`. | ||
| Node's `assert.deepEqual() algorithm` as a standalone module. Use `util.isDeepStrictEqual()` in case you use Node.js v9.x or higher and only want the strict comparison. |
There was a problem hiding this comment.
You can use { strict: true } for the strict comparison; i think this should be reworded.
ljharb
force-pushed
the
master
branch
2 times, most recently
from
4f7beb7 to
6d62ea4
Compare
Swatkovich
approved these changes
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the comment about the performance part (see https://gist.github.com/substack/2790507#gistcomment-3100007).
Instead, recommend to use
util.isDeepStrictEqual(), if possible.