-
-
Notifications
You must be signed in to change notification settings - Fork 15
Replace table by plot on tm_missing_data #922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Code Coverage SummaryDiff against mainResults for commit: d480e4a Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Unit Tests Summary 1 files 24 suites 15m 36s ⏱️ For more details on these failures and errors, see this check. Results for commit d480e4a. ♻️ This comment has been updated with latest results. |
…g/teal.modules.general into 495_plot_missing@main
Co-authored-by: André Veríssimo <[email protected]> Signed-off-by: Lluís Revilla <[email protected]>
# Pull Request I'm seeing some failures on "Check only affected modules 🎯" when I renamed/removed a file on insightsengineering/teal.modules.general#922. See the [GHA report](https://github.com/insightsengineering/teal.modules.general/actions/runs/19531322258?pr=922) if it is still up: ``` No TESTING_DEPTH default. Setting TESTING_DEPTH=5 Commit msg is: Merge 46c9ec30e1f1947b3aeef81b955822ea6901dd36 into ac4deefcc5fa28dfa671e7698e37829dcd4e411f Check for tests/testthat/test-shinytest2-tm_missing_data.R. sed: can't read tests/testthat/test-shinytest2-tm_missing_data.R tests/testthat/test-shinytest2-tm_misssing_data.R: No such file or directory ``` This is being tested on the insightsengineering/teal.modules.general#922 PR itself For context this was added here #273
…g/teal.modules.general into 495_plot_missing@main
Signed-off-by: Marcin <[email protected]>
Signed-off-by: Marcin <[email protected]>
Remove branch restriction for pull request events Signed-off-by: Marcin <[email protected]>
|
Hey @llrs-roche @averissimo I prepared some fixes in here #952 simple_teal_data <- function() {
data <- within(teal.data::teal_data(), {
require(nestcolor)
iris <- iris
mtcars <- mtcars
})
data
}
data <- within(simple_teal_data(), {
set.seed(123)
add_nas <- function(x) {
x[sample(seq_along(x), floor(length(x) * runif(1, .05, .17)))] <- NA
x
}
iris[] <- lapply(iris, add_nas)
mtcars[] <- lapply(mtcars, add_nas)
mtcars[["cyl"]] <- as.factor(mtcars[["cyl"]])
mtcars[["gear"]] <- as.factor(mtcars[["gear"]])
})
teal::init(
data = data,
modules = tm_missing_data(
label = "Missing data",
plot_height = c(600, 400, 5000),
plot_width = NULL,
datanames = "all",
ggtheme = "gray",
ggplot2_args = list(
"Combinations Hist" = teal.widgets::ggplot2_args(
labs = list(subtitle = "Plot produced by Missing Data Module", caption = NULL)
),
"Combinations Main" = teal.widgets::ggplot2_args(labs = list(title = NULL))
),
pre_output = NULL,
post_output = NULL
)
) |> runApp()
tooo many reqs()? |


Pull Request
Fixes #495
Replaces the table by a plot on "By Variables Levels" tab.
The colors match those in the other plots of the module.
It also required to add a "new" dependency, formatters, which is a dependency of tern, rlistings, rtable. I added it on Suggests.
There is an extra commit to update the lintr names