Skip to content

Commit 70bbaf0

Browse files
committed
Add more pause to ensure the checks are when the app is ready
1 parent 466d5e7 commit 70bbaf0

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

tests/testthat/test-shinytest2-tm_missing_data.R

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ test_that("e2e - tm_missing_data: Initializes without errors", {
4848
encoding_dataset <- app_driver$get_text(paste(app_driver$namespaces(TRUE)$wrapper(NULL), ".help-block"))
4949
testthat::expect_match(encoding_dataset, "Datasets.*iris.*mtcars", all = FALSE)
5050

51-
5251
app_driver$stop()
5352
})
5453

@@ -71,6 +70,7 @@ test_that("e2e - tm_missing_data: Default settings and visibility of the summary
7170

7271
app_driver$click(selector = app_driver$namespaces(TRUE)$module("iris-any_na"))
7372
app_driver$expect_no_validation_error()
73+
app_driver$wait_for_idle()
7474

7575
testthat::expect_true(
7676
app_driver$is_visible(
@@ -86,11 +86,13 @@ test_that("e2e - tm_missing_data: Check default settings and visibility of the c
8686
app_driver <- app_driver_tm_missing_data()
8787

8888
app_driver$expect_no_shiny_error()
89+
app_driver$wait_for_idle()
8990

9091
# combination graph
91-
9292
app_driver$set_active_module_input("iris-summary_type", "Combinations")
9393
app_driver$expect_no_validation_error()
94+
app_driver$wait_for_idle()
95+
9496
testthat::expect_true(
9597
app_driver$is_visible(
9698
app_driver$namespaces(TRUE)$module("iris-combination_plot-plot_out_main .shiny-plot-output")
@@ -107,6 +109,7 @@ test_that("e2e - tm_missing_data: Check default settings and visibility of the c
107109

108110
testthat::expect_equal(app_driver$get_active_module_input("iris-combination_cutoff"), 1L)
109111
app_driver$set_active_module_input("iris-combination_cutoff", 10L)
112+
app_driver$wait_for_idle()
110113
testthat::expect_equal(app_driver$get_active_module_input("iris-combination_cutoff"), 10L)
111114
app_driver$expect_no_validation_error()
112115

@@ -119,7 +122,7 @@ test_that("e2e - tm_missing_data: Validate functionality and UI response for 'By
119122
# By variable levels
120123
app_driver$set_active_module_input("iris-summary_type", "By Variable Levels")
121124
app_driver$expect_no_validation_error()
122-
125+
app_driver$wait_for_idle()
123126

124127
testthat::expect_equal(
125128
app_driver$get_active_module_input("iris-group_by_var"),
@@ -132,12 +135,14 @@ test_that("e2e - tm_missing_data: Validate functionality and UI response for 'By
132135

133136
app_driver$set_active_module_input("iris-group_by_vals", c("versicolor", "virginica"))
134137
app_driver$expect_no_validation_error()
138+
app_driver$wait_for_idle()
135139

136140
testthat::expect_equal(
137141
app_driver$get_active_module_input("iris-count_type"),
138142
"counts"
139143
)
140144
app_driver$set_active_module_input("iris-count_type", "proportions")
145+
app_driver$wait_for_idle()
141146
testthat::expect_true(app_driver$is_visible(app_driver$namespaces(TRUE)$module("iris-levels_table")))
142147

143148
app_driver$stop()
@@ -148,6 +153,7 @@ test_that("e2e - tm_missing_data: Validate 'By Variable Levels' table values", {
148153
app_driver <- app_driver_tm_missing_data()
149154

150155
app_driver$set_active_module_input("iris-summary_type", "By Variable Levels")
156+
app_driver$wait_for_idle()
151157
levels_table <- app_driver$namespaces(TRUE)$module("iris-levels_table") %>%
152158
app_driver$get_html_rvest() %>%
153159
rvest::html_table(fill = TRUE) %>%

0 commit comments

Comments
 (0)