Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builtins] Introduce 'ReadKnownError' to fully monomorphize 'readKnown' #4398

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

effectfully
Copy link
Contributor

Do not look here yet.

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'afe6dcd54' (base) and '9e19b3c20' (PR)

Script afe6dcd 9e19b3c Change
auction_1-1 297.3 μs 287.8 μs -3.2%
auction_1-2 965.0 μs 958.3 μs -0.7%
auction_1-3 962.4 μs 954.2 μs -0.9%
auction_1-4 389.6 μs 375.4 μs -3.6%
auction_2-1 298.9 μs 288.4 μs -3.5%
auction_2-2 967.1 μs 960.8 μs -0.7%
auction_2-3 1.230 ms 1.219 ms -0.9%
auction_2-4 964.7 μs 957.0 μs -0.8%
auction_2-5 390.4 μs 376.2 μs -3.6%
crowdfunding-success-1 351.6 μs 339.4 μs -3.5%
crowdfunding-success-2 351.2 μs 339.7 μs -3.3%
crowdfunding-success-3 353.4 μs 339.8 μs -3.8%
currency-1 382.0 μs 374.2 μs -2.0%
escrow-redeem_1-1 561.0 μs 547.7 μs -2.4%
escrow-redeem_1-2 561.0 μs 548.6 μs -2.2%
escrow-redeem_2-1 653.0 μs 641.7 μs -1.7%
escrow-redeem_2-2 652.9 μs 643.0 μs -1.5%
escrow-redeem_2-3 653.3 μs 643.8 μs -1.5%
escrow-refund-1 261.0 μs 253.1 μs -3.0%
future-increase-margin-1 380.7 μs 376.9 μs -1.0%
future-increase-margin-2 845.2 μs 836.3 μs -1.1%
future-increase-margin-3 840.9 μs 834.1 μs -0.8%
future-increase-margin-4 772.7 μs 764.5 μs -1.1%
future-increase-margin-5 1.174 ms 1.170 ms -0.3%
future-pay-out-1 380.5 μs 375.2 μs -1.4%
future-pay-out-2 845.3 μs 834.6 μs -1.3%
future-pay-out-3 846.0 μs 834.0 μs -1.4%
future-pay-out-4 1.173 ms 1.166 ms -0.6%
future-settle-early-1 382.4 μs 374.3 μs -2.1%
future-settle-early-2 849.1 μs 831.8 μs -2.0%
future-settle-early-3 846.7 μs 830.9 μs -1.9%
future-settle-early-4 911.7 μs 902.5 μs -1.0%
game-sm-success_1-1 624.9 μs 611.7 μs -2.1%
game-sm-success_1-2 332.6 μs 318.9 μs -4.1%
game-sm-success_1-3 971.0 μs 960.0 μs -1.1%
game-sm-success_1-4 385.8 μs 373.1 μs -3.3%
game-sm-success_2-1 623.2 μs 610.9 μs -2.0%
game-sm-success_2-2 331.9 μs 318.4 μs -4.1%
game-sm-success_2-3 971.0 μs 959.5 μs -1.2%
game-sm-success_2-4 386.4 μs 374.4 μs -3.1%
game-sm-success_2-5 968.7 μs 962.6 μs -0.6%
game-sm-success_2-6 386.9 μs 375.0 μs -3.1%
multisig-sm-1 630.8 μs 619.5 μs -1.8%
multisig-sm-2 618.5 μs 607.6 μs -1.8%
multisig-sm-3 626.6 μs 613.9 μs -2.0%
multisig-sm-4 634.2 μs 623.0 μs -1.8%
multisig-sm-5 855.3 μs 850.6 μs -0.5%
multisig-sm-6 627.9 μs 617.9 μs -1.6%
multisig-sm-7 615.6 μs 605.4 μs -1.7%
multisig-sm-8 622.2 μs 612.1 μs -1.6%
multisig-sm-9 631.2 μs 618.4 μs -2.0%
multisig-sm-10 855.2 μs 849.0 μs -0.7%
ping-pong-1 521.5 μs 513.6 μs -1.5%
ping-pong-2 520.4 μs 512.3 μs -1.6%
ping-pong_2-1 322.3 μs 316.2 μs -1.9%
prism-1 276.4 μs 267.4 μs -3.3%
prism-2 674.4 μs 660.0 μs -2.1%
prism-3 581.4 μs 572.5 μs -1.5%
pubkey-1 235.0 μs 227.3 μs -3.3%
stablecoin_1-1 1.374 ms 1.358 ms -1.2%
stablecoin_1-2 325.3 μs 312.6 μs -3.9%
stablecoin_1-3 1.579 ms 1.560 ms -1.2%
stablecoin_1-4 345.9 μs 332.6 μs -3.8%
stablecoin_1-5 2.024 ms 1.987 ms -1.8%
stablecoin_1-6 429.1 μs 410.7 μs -4.3%
stablecoin_2-1 1.373 ms 1.353 ms -1.5%
stablecoin_2-2 322.8 μs 312.0 μs -3.3%
stablecoin_2-3 1.577 ms 1.550 ms -1.7%
stablecoin_2-4 344.2 μs 331.4 μs -3.7%
token-account-1 296.7 μs 289.5 μs -2.4%
token-account-2 516.6 μs 511.6 μs -1.0%
uniswap-1 612.2 μs 606.1 μs -1.0%
uniswap-2 356.9 μs 347.0 μs -2.8%
uniswap-3 2.580 ms 2.543 ms -1.4%
uniswap-4 570.0 μs 548.6 μs -3.8%
uniswap-5 1.820 ms 1.788 ms -1.8%
uniswap-6 541.1 μs 523.5 μs -3.3%
vesting-1 536.3 μs 532.5 μs -0.7%

@effectfully
Copy link
Contributor Author

/benchmark plutus-benchmark:validation

@iohk-devops
Copy link

Comparing benchmark results of 'plutus-benchmark:validation' on 'afe6dcd54' (base) and '9e19b3c20' (PR)

Script afe6dcd 9e19b3c Change
auction_1-1 298.3 μs 288.1 μs -3.4%
auction_1-2 966.2 μs 964.7 μs -0.2%
auction_1-3 966.5 μs 960.4 μs -0.6%
auction_1-4 390.6 μs 377.9 μs -3.3%
auction_2-1 299.2 μs 288.9 μs -3.4%
auction_2-2 966.9 μs 963.0 μs -0.4%
auction_2-3 1.229 ms 1.222 ms -0.6%
auction_2-4 964.7 μs 957.5 μs -0.7%
auction_2-5 390.9 μs 376.8 μs -3.6%
crowdfunding-success-1 352.4 μs 340.5 μs -3.4%
crowdfunding-success-2 353.7 μs 340.9 μs -3.6%
crowdfunding-success-3 353.8 μs 339.8 μs -4.0%
currency-1 382.1 μs 375.6 μs -1.7%
escrow-redeem_1-1 559.6 μs 549.9 μs -1.7%
escrow-redeem_1-2 559.2 μs 549.6 μs -1.7%
escrow-redeem_2-1 652.9 μs 640.5 μs -1.9%
escrow-redeem_2-2 652.5 μs 640.3 μs -1.9%
escrow-redeem_2-3 652.7 μs 640.8 μs -1.8%
escrow-refund-1 260.7 μs 252.6 μs -3.1%
future-increase-margin-1 380.4 μs 375.2 μs -1.4%
future-increase-margin-2 848.2 μs 830.3 μs -2.1%
future-increase-margin-3 844.8 μs 830.8 μs -1.7%
future-increase-margin-4 773.1 μs 767.3 μs -0.8%
future-increase-margin-5 1.173 ms 1.172 ms -0.1%
future-pay-out-1 381.0 μs 375.4 μs -1.5%
future-pay-out-2 848.3 μs 835.9 μs -1.5%
future-pay-out-3 850.7 μs 833.6 μs -2.0%
future-pay-out-4 1.176 ms 1.168 ms -0.7%
future-settle-early-1 381.1 μs 375.2 μs -1.5%
future-settle-early-2 846.8 μs 835.1 μs -1.4%
future-settle-early-3 847.3 μs 839.1 μs -1.0%
future-settle-early-4 909.5 μs 905.9 μs -0.4%
game-sm-success_1-1 626.0 μs 616.8 μs -1.5%
game-sm-success_1-2 331.3 μs 320.0 μs -3.4%
game-sm-success_1-3 972.5 μs 964.2 μs -0.9%
game-sm-success_1-4 387.7 μs 375.0 μs -3.3%
game-sm-success_2-1 624.3 μs 615.3 μs -1.4%
game-sm-success_2-2 331.8 μs 319.6 μs -3.7%
game-sm-success_2-3 974.3 μs 959.9 μs -1.5%
game-sm-success_2-4 388.2 μs 373.5 μs -3.8%
game-sm-success_2-5 976.8 μs 959.5 μs -1.8%
game-sm-success_2-6 388.2 μs 374.0 μs -3.7%
multisig-sm-1 629.5 μs 617.0 μs -2.0%
multisig-sm-2 616.9 μs 605.6 μs -1.8%
multisig-sm-3 624.1 μs 611.4 μs -2.0%
multisig-sm-4 630.3 μs 617.9 μs -2.0%
multisig-sm-5 857.6 μs 849.8 μs -0.9%
multisig-sm-6 629.6 μs 617.2 μs -2.0%
multisig-sm-7 615.4 μs 607.4 μs -1.3%
multisig-sm-8 623.4 μs 613.5 μs -1.6%
multisig-sm-9 632.9 μs 619.7 μs -2.1%
multisig-sm-10 856.8 μs 847.0 μs -1.1%
ping-pong-1 521.2 μs 513.2 μs -1.5%
ping-pong-2 519.6 μs 516.1 μs -0.7%
ping-pong_2-1 323.1 μs 319.0 μs -1.3%
prism-1 275.9 μs 267.1 μs -3.2%
prism-2 674.9 μs 663.2 μs -1.7%
prism-3 582.4 μs 572.5 μs -1.7%
pubkey-1 235.1 μs 228.0 μs -3.0%
stablecoin_1-1 1.378 ms 1.352 ms -1.9%
stablecoin_1-2 325.3 μs 312.6 μs -3.9%
stablecoin_1-3 1.584 ms 1.553 ms -2.0%
stablecoin_1-4 346.1 μs 330.9 μs -4.4%
stablecoin_1-5 2.024 ms 1.979 ms -2.2%
stablecoin_1-6 427.7 μs 410.5 μs -4.0%
stablecoin_2-1 1.371 ms 1.356 ms -1.1%
stablecoin_2-2 322.8 μs 313.6 μs -2.9%
stablecoin_2-3 1.575 ms 1.559 ms -1.0%
stablecoin_2-4 343.9 μs 332.8 μs -3.2%
token-account-1 297.7 μs 289.8 μs -2.7%
token-account-2 518.8 μs 511.7 μs -1.4%
uniswap-1 613.6 μs 608.3 μs -0.9%
uniswap-2 359.0 μs 348.1 μs -3.0%
uniswap-3 2.593 ms 2.554 ms -1.5%
uniswap-4 568.1 μs 550.3 μs -3.1%
uniswap-5 1.816 ms 1.781 ms -1.9%
uniswap-6 542.9 μs 525.2 μs -3.3%
vesting-1 537.7 μs 531.5 μs -1.2%

@effectfully effectfully force-pushed the effectfully/builtins/fully-monomorphize-readKnown branch from 9e19b3c to d4f933d Compare February 13, 2022 14:44
@effectfully
Copy link
Contributor Author

Continuing to monomorphize things, especially those that are related to unlifting, 'cause for whatever reason that speeds things up quite a bit. Ready for review.

@michaelpj michaelpj merged commit 63f5ec4 into master Feb 14, 2022
@effectfully effectfully deleted the effectfully/builtins/fully-monomorphize-readKnown branch February 14, 2022 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants