Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Builtins] Introduce 'TypeSchemeRuntime' #4246

Conversation

effectfully
Copy link
Contributor

A rebase of #4244.

@effectfully
Copy link
Contributor Author

/benchmark

@effectfully effectfully force-pushed the effectfully/builtins/evaluation/introduce-TypeSchemeRuntime-2 branch from 0dbd2dd to d03d76b Compare November 27, 2021 22:50
@effectfully
Copy link
Contributor Author

/benchmark

@iohk-devops
Copy link

Comparing benchmark results of 'ae5f8b3ff' (base) and 'd03d76bff' (PR)

Script ae5f8b3 d03d76b Change
auction_1-1 407.8 μs 420.4 μs +3.1%
auction_1-2 1.197 ms 1.224 ms +2.3%
auction_1-3 1.199 ms 1.230 ms +2.6%
auction_1-4 542.0 μs 558.9 μs +3.1%
auction_2-1 408.2 μs 422.2 μs +3.4%
auction_2-2 1.194 ms 1.223 ms +2.4%
auction_2-3 1.507 ms 1.541 ms +2.3%
auction_2-4 1.203 ms 1.229 ms +2.2%
auction_2-5 542.2 μs 559.5 μs +3.2%
crowdfunding-success-1 485.9 μs 502.6 μs +3.4%
crowdfunding-success-2 485.4 μs 502.4 μs +3.5%
crowdfunding-success-3 486.0 μs 502.0 μs +3.3%
currency-1 491.6 μs 504.8 μs +2.7%
escrow-redeem_1-1 750.0 μs 768.9 μs +2.5%
escrow-redeem_1-2 749.5 μs 767.6 μs +2.4%
escrow-redeem_2-1 857.8 μs 884.7 μs +3.1%
escrow-redeem_2-2 857.4 μs 885.2 μs +3.2%
escrow-redeem_2-3 856.4 μs 883.0 μs +3.1%
escrow-refund-1 358.0 μs 369.4 μs +3.2%
future-increase-margin-1 492.0 μs 506.0 μs +2.8%
future-increase-margin-2 1.083 ms 1.110 ms +2.5%
future-increase-margin-3 1.083 ms 1.111 ms +2.6%
future-increase-margin-4 983.4 μs 1.009 ms +2.6%
future-increase-margin-5 1.435 ms 1.469 ms +2.4%
future-pay-out-1 491.4 μs 505.5 μs +2.9%
future-pay-out-2 1.087 ms 1.107 ms +1.8%
future-pay-out-3 1.089 ms 1.108 ms +1.7%
future-pay-out-4 1.438 ms 1.459 ms +1.5%
future-settle-early-1 492.6 μs 505.9 μs +2.7%
future-settle-early-2 1.086 ms 1.109 ms +2.1%
future-settle-early-3 1.085 ms 1.111 ms +2.4%
future-settle-early-4 1.130 ms 1.155 ms +2.2%
game-sm-success_1-1 823.8 μs 842.5 μs +2.3%
game-sm-success_1-2 459.0 μs 472.4 μs +2.9%
game-sm-success_1-3 1.211 ms 1.236 ms +2.1%
game-sm-success_1-4 536.8 μs 552.3 μs +2.9%
game-sm-success_2-1 826.2 μs 845.3 μs +2.3%
game-sm-success_2-2 459.1 μs 474.2 μs +3.3%
game-sm-success_2-3 1.214 ms 1.243 ms +2.4%
game-sm-success_2-4 534.7 μs 553.6 μs +3.5%
game-sm-success_2-5 1.212 ms 1.242 ms +2.5%
game-sm-success_2-6 533.8 μs 552.6 μs +3.5%
multisig-sm-1 826.4 μs 849.0 μs +2.7%
multisig-sm-2 817.5 μs 834.0 μs +2.0%
multisig-sm-3 823.9 μs 840.5 μs +2.0%
multisig-sm-4 831.0 μs 851.0 μs +2.4%
multisig-sm-5 1.080 ms 1.097 ms +1.6%
multisig-sm-6 830.2 μs 848.1 μs +2.2%
multisig-sm-7 819.7 μs 836.5 μs +2.0%
multisig-sm-8 828.0 μs 843.1 μs +1.8%
multisig-sm-9 835.0 μs 847.7 μs +1.5%
multisig-sm-10 1.078 ms 1.100 ms +2.0%
ping-pong-1 685.6 μs 702.3 μs +2.4%
ping-pong-2 685.6 μs 704.6 μs +2.8%
ping-pong_2-1 440.5 μs 453.0 μs +2.8%
prism-1 381.8 μs 395.6 μs +3.6%
prism-2 884.5 μs 915.2 μs +3.5%
prism-3 761.5 μs 790.5 μs +3.8%
pubkey-1 326.0 μs 338.3 μs +3.8%
stablecoin_1-1 1.695 ms 1.746 ms +3.0%
stablecoin_1-2 450.2 μs 462.9 μs +2.8%
stablecoin_1-3 1.940 ms 2.006 ms +3.4%
stablecoin_1-4 476.8 μs 491.7 μs +3.1%
stablecoin_1-5 2.476 ms 2.570 ms +3.8%
stablecoin_1-6 594.9 μs 610.2 μs +2.6%
stablecoin_2-1 1.705 ms 1.742 ms +2.2%
stablecoin_2-2 450.5 μs 462.0 μs +2.6%
stablecoin_2-3 1.947 ms 2.001 ms +2.8%
stablecoin_2-4 476.6 μs 490.1 μs +2.8%
token-account-1 391.3 μs 398.7 μs +1.9%
token-account-2 684.7 μs 703.6 μs +2.8%
uniswap-1 768.9 μs 789.6 μs +2.7%
uniswap-2 474.9 μs 487.8 μs +2.7%
uniswap-3 3.149 ms 3.234 ms +2.7%
uniswap-4 773.9 μs 798.1 μs +3.1%
uniswap-5 2.256 ms 2.320 ms +2.8%
uniswap-6 740.8 μs 759.4 μs +2.5%
vesting-1 699.3 μs 718.8 μs +2.8%

@effectfully
Copy link
Contributor Author

So this truly does give us a slowdown. It might be related to the MachineParameters no longer being a value meaning I could've broken some sharing in the benchmarks. I'll look into it.

@effectfully
Copy link
Contributor Author

I don't have ideas on how to improve that and we might not need it in the end, so closing for now.

@kwxm kwxm deleted the effectfully/builtins/evaluation/introduce-TypeSchemeRuntime-2 branch February 2, 2022 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Builtins Evaluation EXPERIMENT Experiments that we probably don't want to merge Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants