Remove pending certificate from explorer #2061
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlachaume
approved these changes
Oct 30, 2024
Collaborator
dlachaume
left a comment
dlachaume
left a comment
There was a problem hiding this comment.
LGTM 🚀. Thanks for adapting after the refactoring of the protocol parameters naming!
Alenar
force-pushed
the
djo/2025/remove_pending_cert_from_explorer
branch
from
bc5ad1b to
b97b850
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
As it's now deprecated.
…ing component * Remove `Protocol Parameters` as it's deprecated * Rename `Next Protocol Parameters` to `Registration Protocol Parameters` and use `signer_registration_protocol` as source with a fallback to `next_protocol` if missing (for retrocompatibility with old aggregators). Refs: #1966
Now data will be updated even if the auto refresh is paused if: - at first loading - when the selected aggregator is changed
But disabled if the data needed to construct their target url is not yet available.
Alenar
force-pushed
the
djo/2025/remove_pending_cert_from_explorer
branch
from
b97b850 to
825e6ab
Compare
Alenar
temporarily deployed
to
testing-preview
GitHub Actions
Inactive
Alenar
temporarily deployed
to
testing-sanchonet
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content
This PR include remove the Pending Certificate component from the explorer.
To fill part of the empty place left by it the
Epoch Settingscomponent layout is changed to be horizontal, plus this supplementary horizontal space allow to show its two buttons ("signer registrations" & "in/out registrations") instead of stacking them.Here is how it looks:
This PR also:
Epoch Settingscomponent to the new naming scheme defined in Refactor protocol parameters namings in signer/aggregator #1966 (with a fallback for aggregator that have still be updated).pause/resumebutton.Pre-submit checklist
Issue(s)
Closes #2025, closes #1966