-
Notifications
You must be signed in to change notification settings - Fork 52
Refactor event store to use migration mechanism #2043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor event store to use migration mechanism #2043
Conversation
Test Results 4 files ±0 55 suites ±0 10m 25s ⏱️ ±0s Results for commit 9a7bf92. ± Comparison against base commit 63e1204. This pull request removes 3 and adds 5 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
e9a8296 to
d67e3fe
Compare
jpraynaud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Alenar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dlachaume
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
| let mut rows = self.connection.fetch(InsertEventQuery::one(message)?)?; | ||
|
|
||
| rows.next().ok_or(anyhow!( | ||
| "No record from the database after I saved event message {log_message:?}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This error message was already present before, but I find the phrasing a bit strange with the use of 'I'. What do you think?
| "No record from the database after I saved event message {log_message:?}" | |
| "No record from the database after saving event message {log_message:?}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
99fbdf1 to
bb82041
Compare
…ord, repository, query)
* mithril-aggregator from `0.5.89` to `0.5.90`
978854d to
9a7bf92
Compare
Content
This PR implement migration mechanism for the event_store module.
The
event_storemodule is reorganized to embedded adatabasefolder with the same structure than themithril-aggregator::databaseone.The WAL is activated on the event_store connection
Pre-submit checklist
Comments
We do not create a folder for
repository,recordandquerybut just a file because there is only one structure in each one.If we have to add other structure, we can create this directory later transparently for the other modules.
Issue(s)
Relates to #2023