Skip to content

Make Cardano transaction client stable #1989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 10, 2024
Merged

Make Cardano transaction client stable #1989

merged 12 commits into from
Oct 10, 2024

Conversation

@dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Oct 8, 2024 •
edited
Loading

Content

This PR includes the stabilization of the Cardano transaction client, previously available as an unstable feature.

This update ensures the Cardano transaction client is now stable using mithril-client, mithril-client-cli and mithril-client-wasm.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1952

@dlachaume dlachaume self-assigned this Oct 8, 2024
@dlachaume dlachaume force-pushed the dlachaume/1952/make-cardano-transactions-stable-in-client branch from 4dedea9 to 80547b5 Compare October 8, 2024 16:14
@github-actions
Copy link

github-actions bot commented Oct 8, 2024 •
edited
Loading

Test Results

    4 files  ±0     54 suites  ±0   9m 35s ⏱️ +2s
1 330 tests  - 1  1 330 ✅  - 1  0 💤 ±0  0 ❌ ±0 
1 538 runs   - 4  1 538 ✅  - 4  0 💤 ±0  0 ❌ ±0 

Results for commit 49e2230. ± Comparison against base commit ef0c28a.

This pull request removes 1 test. 
mithril-client-cli::bin/mithril-client ‑ tests::fail_if_cardano_tx_command_is_used_without_unstable_flag

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-sanchonet October 8, 2024 16:22 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1952/make-cardano-transactions-stable-in-client branch from 80547b5 to 83dee5c Compare October 8, 2024 17:00
@dlachaume dlachaume temporarily deployed to testing-sanchonet October 8, 2024 17:07 — with GitHub Actions Inactive
@dlachaume dlachaume marked this pull request as ready for review October 8, 2024 17:57
jpraynaud
jpraynaud approved these changes Oct 9, 2024
View reviewed changes
Copy link
Member

@jpraynaud jpraynaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dlachaume
docs: announce the stable status of Cardano transaction in CHANGELOG
eec0a1f
@dlachaume
chore: bump crates versions
b8ac5d4 
* client-cardano-transaction from `0.1.11` to `0.1.12`
* mithril-client-cli from `0.9.13` to `0.9.14`
* mithril-client-wasm from `0.5.0` to `0.5.1`
* mithril-client from `0.9.0` to `0.9.1`
* mithril-end-to-end from `0.4.35` to `0.4.36`
@dlachaume
chore: upgrade mithril-explorer dependencies
8ebd3e5
@dlachaume
chore: upgrade www and www-test dependencies and bump packages ve…
49e2230 
…rsions
@dlachaume dlachaume force-pushed the dlachaume/1952/make-cardano-transactions-stable-in-client branch from 83dee5c to 49e2230 Compare October 9, 2024 08:45
@dlachaume dlachaume temporarily deployed to testing-sanchonet October 9, 2024 08:55 — with GitHub Actions Inactive
Alenar
Alenar approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

sfauvel
sfauvel approved these changes Oct 9, 2024
View reviewed changes
Copy link
Collaborator

@sfauvel sfauvel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dlachaume dlachaume merged commit 3c7fdab into main Oct 10, 2024
46 checks passed
@dlachaume dlachaume deleted the dlachaume/1952/make-cardano-transactions-stable-in-client branch October 10, 2024 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Alenar Alenar Alenar approved these changes

@jpraynaud jpraynaud jpraynaud approved these changes

+1 more reviewer

@sfauvel sfauvel sfauvel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@dlachaume dlachaume

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Make Cardano transactions stable in client

5 participants

@dlachaume @Alenar @sfauvel @jpraynaud