-
Notifications
You must be signed in to change notification settings - Fork 52
Refactor: standardize epoch settings naming #1949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test Results 4 files ±0 54 suites ±0 9m 48s ⏱️ +9s Results for commit d8880b4. ± Comparison against base commit a0d6680. This pull request removes 10 and adds 10 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
471bc9c to
886393d
Compare
acd39cb to
b8c7aba
Compare
Alenar
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
446bdc3 to
4470fee
Compare
4470fee to
eb2b54d
Compare
jpraynaud
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
…ttings` Co-authored-by: Sébastien Fauvel <[email protected]>
eb2b54d to
d8880b4
Compare
Content
This PR includes refactoring of epoch settings:
EpochSettingsfrom common toSignerEpochSettingsin the signerEpochSettingtoEpochSettingsProtocolParametersStorertrait toEpochSettingsStorerPre-submit checklist