test(aggregator): use simpler method to build sqlite connection in certificate_repository

Author: Alenar

mithril-aggregator/src/database/repository/certificate_repository.rs

@@ -130,8 +130,6 @@ mod tests {
     use mithril_common::crypto_helper::tests_setup::setup_certificate_chain;
 
     use crate::database::test_helper::{insert_certificate_records, main_db_connection};
-    use crate::dependency_injection::DependenciesBuilder;
-    use crate::Configuration;
 
     use super::*;
 
@@ -239,8 +237,7 @@ mod tests {
     async fn repository_get_certificate() {
         let (certificates, _) = setup_certificate_chain(5, 2);
         let expected_hash = certificates[0].hash.clone();
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         insert_certificate_records(&connection, certificates.clone());
 
         let repository: CertificateRepository = CertificateRepository::new(connection);
@@ -262,8 +259,7 @@ mod tests {
     #[tokio::test]
     async fn repository_get_latest_certificates() {
         let (certificates, _) = setup_certificate_chain(5, 2);
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         insert_certificate_records(&connection, certificates.clone());
 
         let repository = CertificateRepository::new(connection);
@@ -278,8 +274,7 @@ mod tests {
 
     #[tokio::test]
     async fn get_master_certificate_no_certificate_recorded_returns_none() {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
 
         let repository: CertificateRepository = CertificateRepository::new(connection);
         let certificate = repository
@@ -292,8 +287,7 @@ mod tests {
 
     #[tokio::test]
     async fn get_master_certificate_one_cert_in_current_epoch_recorded_returns_that_one() {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let certificate = CertificateRecord::dummy_genesis("1", Epoch(1), 1);
         let expected_certificate: Certificate = certificate.clone().into();
         insert_certificate_records(&connection, vec![certificate]);
@@ -311,8 +305,7 @@ mod tests {
     #[tokio::test]
     async fn get_master_certificate_multiple_cert_in_current_epoch_returns_first_of_current_epoch()
     {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let certificates = vec![
             CertificateRecord::dummy_genesis("1", Epoch(1), 1),
             CertificateRecord::dummy_db_snapshot("2", "1", Epoch(1), 2),
@@ -334,8 +327,7 @@ mod tests {
     #[tokio::test]
     async fn get_master_certificate_multiple_cert_in_previous_epoch_none_in_the_current_returns_first_of_previous_epoch(
     ) {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let certificates = vec![
             CertificateRecord::dummy_genesis("1", Epoch(1), 1),
             CertificateRecord::dummy_db_snapshot("2", "1", Epoch(1), 2),
@@ -357,8 +349,7 @@ mod tests {
     #[tokio::test]
     async fn get_master_certificate_multiple_cert_in_previous_one_cert_in_current_epoch_returns_one_in_current_epoch(
     ) {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let certificates = vec![
             CertificateRecord::dummy_genesis("1", Epoch(1), 1),
             CertificateRecord::dummy_db_snapshot("2", "1", Epoch(1), 2),
@@ -381,8 +372,7 @@ mod tests {
     #[tokio::test]
     async fn get_master_certificate_multiple_cert_in_previous_multiple_in_current_epoch_returns_first_of_current_epoch(
     ) {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let certificates = vec![
             CertificateRecord::dummy_genesis("1", Epoch(1), 1),
             CertificateRecord::dummy_db_snapshot("2", "1", Epoch(1), 2),
@@ -406,8 +396,7 @@ mod tests {
     #[tokio::test]
     async fn get_master_certificate_multiple_cert_in_penultimate_epoch_none_in_previous_returns_none(
     ) {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let certificates = vec![
             CertificateRecord::dummy_genesis("1", Epoch(1), 1),
             CertificateRecord::dummy_db_snapshot("2", "1", Epoch(1), 2),
@@ -427,8 +416,7 @@ mod tests {
     #[tokio::test]
     async fn get_master_certificate_second_genesis_after_multiple_cert_in_current_epoch_returns_last_genesis(
     ) {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let certificates = vec![
             CertificateRecord::dummy_genesis("1", Epoch(1), 1),
             CertificateRecord::dummy_db_snapshot("2", "1", Epoch(1), 2),
@@ -451,8 +439,7 @@ mod tests {
     #[tokio::test]
     async fn get_master_certificate_second_genesis_after_multiple_cert_in_multiple_epochs_returns_last_genesis(
     ) {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let certificates = vec![
             CertificateRecord::dummy_genesis("1", Epoch(1), 1),
             CertificateRecord::dummy_db_snapshot("2", "1", Epoch(1), 2),
@@ -477,8 +464,7 @@ mod tests {
     #[tokio::test]
     async fn get_master_certificate_new_genesis_after_multiple_cert_in_previous_epoch_returns_last_genesis(
     ) {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let certificates = vec![
             CertificateRecord::dummy_genesis("1", Epoch(1), 1),
             CertificateRecord::dummy_db_snapshot("2", "1", Epoch(1), 2),
@@ -503,8 +489,7 @@ mod tests {
         let (certificates, _) = setup_certificate_chain(3, 1);
         let expected_certificate_id = &certificates[2].hash;
         let epoch = &certificates[2].epoch;
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         insert_certificate_records(&connection, certificates.clone());
 
         let repository: CertificateRepository = CertificateRepository::new(connection);
@@ -520,17 +505,15 @@ mod tests {
     #[tokio::test]
     async fn save_certificate() {
         let (certificates, _) = setup_certificate_chain(5, 3);
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
-        let repository: CertificateRepository = CertificateRepository::new(connection);
+        let connection = Arc::new(main_db_connection().unwrap());
+        let repository: CertificateRepository = CertificateRepository::new(connection.clone());
         let certificate = repository
             .create_certificate(certificates[4].clone())
             .await
             .unwrap();
 
         assert_eq!(certificates[4].hash, certificate.hash);
         {
-            let connection = deps.get_sqlite_connection().await.unwrap();
             let cert = connection
                 .fetch_first(GetCertificateRecordQuery::by_certificate_id(
                     &certificates[4].hash,
@@ -544,8 +527,7 @@ mod tests {
 
     #[tokio::test]
     async fn delete_only_given_certificates() {
-        let mut deps = DependenciesBuilder::new_for_test(Configuration::new_sample());
-        let connection = deps.get_sqlite_connection().await.unwrap();
+        let connection = Arc::new(main_db_connection().unwrap());
         let repository = CertificateRepository::new(connection.clone());
         let records = vec![
             CertificateRecord::dummy_genesis("1", Epoch(1), 1),