feat: remove old states from signer state machine

Author: dlachaume

mithril-signer/src/runtime/state_machine.rs

@@ -23,23 +23,6 @@ pub enum SignerState {
         epoch: Epoch,
     },
 
-    /// `Registered` state. The signer has successfully registered against the
-    /// aggregator for this Epoch, it is now able to sign.
-    Registered {
-        /// Epoch when Signer may sign.
-        epoch: Epoch,
-    },
-
-    /// `Signed` state. The signer has signed the message for the
-    /// current pending certificate.
-    Signed {
-        /// Epoch when signer signed.
-        epoch: Epoch,
-
-        /// Entity type that is signed
-        signed_entity_type: SignedEntityType,
-    },
-
     /// `ReadyToSign` state. The signer is registered and ready to sign new messages.
     ReadyToSign {
         /// Time point when signer transited to the state.
@@ -67,11 +50,6 @@ impl SignerState {
         matches!(*self, SignerState::Unregistered { epoch: _ })
     }
 
-    /// Returns `true` if the state in `Registered`
-    pub fn is_registered(&self) -> bool {
-        matches!(*self, SignerState::Registered { epoch: _ })
-    }
-
     /// Returns `true` if the state in `ReadyToSign`
     pub fn is_ready_to_sign(&self) -> bool {
         matches!(
@@ -87,29 +65,13 @@ impl SignerState {
     pub fn is_registered_not_able_to_sign(&self) -> bool {
         matches!(*self, SignerState::RegisteredNotAbleToSign { epoch: _ })
     }
-
-    /// Returns `true` if the state in `Signed`
-    pub fn is_signed(&self) -> bool {
-        matches!(
-            *self,
-            SignerState::Signed {
-                epoch: _,
-                signed_entity_type: _
-            }
-        )
-    }
 }
 
 impl Display for SignerState {
     fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
         match self {
             Self::Init => write!(f, "Init"),
             Self::Unregistered { epoch } => write!(f, "Unregistered - {epoch:?}"),
-            Self::Registered { epoch } => write!(f, "Registered - {epoch}"),
-            Self::Signed {
-                epoch,
-                signed_entity_type,
-            } => write!(f, "Signed - {epoch} - {signed_entity_type:?}"),
             Self::RegisteredNotAbleToSign { epoch } => {
                 write!(f, "RegisteredNotAbleToSign - {epoch}")
             }
@@ -224,15 +186,6 @@ impl StateMachine {
                     info!("→ No epoch settings found yet, waiting…");
                 }
             }
-            SignerState::Registered { epoch: _epoch } => {
-                todo!("Will be removed")
-            }
-            SignerState::Signed {
-                epoch: _epoch,
-                signed_entity_type: _signed_entity_type,
-            } => {
-                todo!("Will be removed")
-            }
             SignerState::RegisteredNotAbleToSign { epoch } => {
                 if let Some(new_epoch) = self.has_epoch_changed(*epoch).await? {
                     info!(" → new Epoch detected, transiting to UNREGISTERED");

mithril-signer/tests/test_extensions/state_machine_tester.rs

@@ -308,19 +308,6 @@ impl StateMachineTester {
         )
     }
 
-    /// cycle the state machine and test the resulting state
-    pub async fn cycle_registered(&mut self) -> Result<&mut Self> {
-        self.cycle().await?;
-
-        self.assert(
-            self.state_machine.get_state().await.is_registered(),
-            format!(
-                "state machine is in {} state (Registered was expected)",
-                self.state_machine.get_state().await
-            ),
-        )
-    }
-
     /// cycle the state machine and test the resulting state
     pub async fn cycle_ready_to_sign(&mut self) -> Result<&mut Self> {
         self.cycle().await?;
@@ -372,19 +359,6 @@ impl StateMachineTester {
         )
     }
 
-    /// cycle the state machine and test the resulting state
-    pub async fn cycle_signed(&mut self) -> Result<&mut Self> {
-        self.cycle().await?;
-
-        self.assert(
-            self.state_machine.get_state().await.is_signed(),
-            format!(
-                "state machine is in {} state (Signed was expected)",
-                self.state_machine.get_state().await
-            ),
-        )
-    }
-
     /// cycle the state machine and test the resulting state
     pub async fn cycle_unregistered(&mut self) -> Result<&mut Self> {
         self.cycle().await?;