Implement fake digest #146

Author: jpraynaud

mithril-network/mithril-aggregator/src/fake_data.rs

@@ -17,6 +17,17 @@ pub fn beacon() -> entities::Beacon {
     entities::Beacon::new(network, epoch, block)
 }
 
+/// Fake Digest
+pub fn digest() -> Vec<u8> {
+    let beacon = beacon();
+    format!(
+        "digest-{}-{}-{}",
+        beacon.network, beacon.epoch, beacon.block
+    )
+    .as_bytes()
+    .to_vec()
+}
+
 /// Fake ProtocolParameters
 pub fn protocol_parameters() -> entities::ProtocolParameters {
     let k = 5;

mithril-network/mithril-aggregator/src/http_server.rs

@@ -282,6 +282,8 @@ mod handlers {
         debug!("register_signatures/{:?}", signatures);
 
         let mut multi_signer = multi_signer.write().await;
+        let message = fake_data::digest();
+        multi_signer.update_current_message(message).unwrap();
         for signature in &signatures {
             match &multi_signer::key_decode_hex(signature.signature.clone()) {
                 Ok(single_signature) => {
@@ -617,6 +619,10 @@ mod tests {
     #[tokio::test]
     async fn test_register_signatures_post_ok() {
         let mut mock_multi_signer = MockMultiSigner::new();
+        mock_multi_signer
+            .expect_update_current_message()
+            .return_const(Ok(()))
+            .once();
         mock_multi_signer
             .expect_register_single_signature()
             .return_const(Ok(()))
@@ -648,6 +654,10 @@ mod tests {
     #[tokio::test]
     async fn test_register_signatures_post_ko() {
         let mut mock_multi_signer = MockMultiSigner::new();
+        mock_multi_signer
+            .expect_update_current_message()
+            .return_const(Ok(()))
+            .once();
         mock_multi_signer
             .expect_register_single_signature()
             .return_const(Err("an error occurred".to_string()))

mithril-network/mithril-aggregator/src/multi_signer.rs

@@ -41,6 +41,12 @@ use mockall::automock;
 /// MultiSigner is the cryptographic engine in charge of producing multi signatures from individual signatures
 #[cfg_attr(test, automock)]
 pub trait MultiSigner: Sync + Send {
+    /// Get current message
+    fn get_current_message(&self) -> Option<Bytes>;
+
+    /// Update current message
+    fn update_current_message(&mut self, message: Bytes) -> Result<(), String>;
+
     /// Get protocol parameters
     fn get_protocol_parameters(&self) -> Option<ProtocolParameters>;
 
@@ -89,6 +95,7 @@ pub trait MultiSigner: Sync + Send {
 
 /// MultiSignerImpl is an implementation of the MultiSigner
 pub struct MultiSignerImpl {
+    current_message: Option<Bytes>,
     protocol_parameters: Option<ProtocolParameters>,
     stakes: Vec<(ProtocolPartyId, ProtocolStake)>,
     signers: HashMap<ProtocolPartyId, ProtocolSignerVerificationKey>,
@@ -108,6 +115,7 @@ impl MultiSignerImpl {
     pub fn new() -> Self {
         debug!("New MultiSignerImpl created");
         Self {
+            current_message: None,
             protocol_parameters: None,
             stakes: Vec::new(),
             signers: HashMap::new(),
@@ -145,6 +153,17 @@ impl MultiSignerImpl {
 }
 
 impl MultiSigner for MultiSignerImpl {
+    /// Get current message
+    fn get_current_message(&self) -> Option<Bytes> {
+        self.current_message.clone()
+    }
+
+    /// Update current message
+    fn update_current_message(&mut self, message: Bytes) -> Result<(), String> {
+        self.current_message = Some(message);
+        Ok(())
+    }
+
     /// Get protocol parameters
     fn get_protocol_parameters(&self) -> Option<ProtocolParameters> {
         self.protocol_parameters
@@ -204,7 +223,7 @@ impl MultiSigner for MultiSignerImpl {
             party_id, index
         );
 
-        let message = &self.message();
+        let message = &self.get_current_message().unwrap();
         let clerk = self.clerk();
         match clerk.verify_sig(signature, index, message) {
             Ok(_) => {
@@ -270,7 +289,7 @@ impl MultiSigner for MultiSignerImpl {
     fn create_multi_signature(&mut self) -> Result<Option<ProtocolMultiSignature>, String> {
         debug!("Create multi signature");
 
-        let message = &self.message();
+        let message = &self.get_current_message().unwrap();
         let signatures: (Vec<ProtocolSingleSignature>, Vec<ProtocolLotteryIndex>) = self
             .single_signatures
             .iter()
@@ -328,6 +347,10 @@ mod tests {
     use rand_chacha::ChaCha20Rng;
     use rand_core::{RngCore, SeedableRng};
 
+    fn message() -> Bytes {
+        Vec::from_hex("7724e03fb8d84a376a43b8f41518a11c").unwrap()
+    }
+
     fn setup_protocol_parameters() -> ProtocolParameters {
         ProtocolParameters {
             m: 10,
@@ -415,6 +438,21 @@ mod tests {
         assert_eq!(secret_key, secret_key_restored);
     }
 
+    #[test]
+    fn test_multi_signer_current_message_ok() {
+        let mut multi_signer = MultiSignerImpl::new();
+
+        let current_message_expected = Vec::from_hex("7724e03fb8d84a376a43b8f41518a11c").unwrap();
+        multi_signer
+            .update_current_message(current_message_expected.clone())
+            .expect("update current message failed");
+
+        let current_message = multi_signer
+            .get_current_message()
+            .expect("current message should have been retrieved");
+        assert_eq!(current_message_expected, current_message)
+    }
+
     #[test]
     fn test_multi_signer_protocol_parameters_ok() {
         let mut multi_signer = MultiSignerImpl::new();
@@ -471,7 +509,11 @@ mod tests {
     #[test]
     fn test_multi_signer_multi_signature_ok() {
         let mut multi_signer = MultiSignerImpl::new();
-        let message = multi_signer.message();
+
+        let message = message();
+        multi_signer
+            .update_current_message(message.clone())
+            .expect("update current message failed");
 
         let protocol_parameters = setup_protocol_parameters();
         multi_signer