test: refactor test_cli_runner return values to improve test readability

Author: dlachaume

mithril-common/src/chain_observer/cli_observer.rs

@@ -572,7 +572,10 @@ mod tests {
     use std::collections::BTreeMap;
 
     use super::*;
-    use crate::{chain_observer::test_cli_runner::TestCliRunner, crypto_helper::ColdKeyGenerator};
+    use crate::{
+        chain_observer::test_cli_runner::{test_cli_runner_values, TestCliRunner},
+        crypto_helper::ColdKeyGenerator,
+    };
 
     use kes_summed_ed25519::{kes::Sum6Kes, traits::KesSk};
 
@@ -581,15 +584,18 @@ mod tests {
         let observer = CardanoCliChainObserver::new(Box::<TestCliRunner>::default());
         let era = observer.get_current_era().await.unwrap().unwrap();
 
-        assert_eq!("Conway".to_string(), era);
+        assert_eq!(
+            test_cli_runner_values::LAUNCH_ERA_EXPECTED_ERA.to_string(),
+            era
+        );
     }
 
     #[tokio::test]
     async fn test_get_current_epoch() {
         let observer = CardanoCliChainObserver::new(Box::<TestCliRunner>::default());
         let epoch = observer.get_current_epoch().await.unwrap().unwrap();
 
-        assert_eq!(Epoch(120), epoch);
+        assert_eq!(test_cli_runner_values::LAUNCH_EPOCH_EXPECTED_EPOCH, epoch);
     }
 
     #[tokio::test]
@@ -599,9 +605,9 @@ mod tests {
 
         assert_eq!(
             ChainPoint {
-                slot_number: SlotNumber(25886617),
-                block_number: BlockNumber(1270276),
-                block_hash: "7383b17d7b05b0953cf0649abff60173995eb9febe556889333e20e1e5b7ca84"
+                slot_number: test_cli_runner_values::LAUNCH_CHAIN_POINT_EXPECTED_SLOT_NUMBER,
+                block_number: test_cli_runner_values::LAUNCH_CHAIN_POINT_EXPECTED_BLOCK_NUMBER,
+                block_hash: test_cli_runner_values::LAUNCH_CHAIN_POINT_EXPECTED_BLOCK_HASH
                     .to_string(),
             },
             chain_point
@@ -655,7 +661,16 @@ mod tests {
         let observer = CardanoCliChainObserver::new(Box::<TestCliRunner>::default());
         let address = "addrtest_123456".to_string();
         let datums = observer.get_current_datums(&address).await.unwrap();
-        assert_eq!(vec![TxDatum(r#"{"constructor":0,"fields":[{"bytes":"5b0a20207b0a20202020226e616d65223a20227468616c6573222c0a202020202265706f6368223a203132330a20207d2c0a20207b0a20202020226e616d65223a20227079746861676f726173222c0a202020202265706f6368223a206e756c6c0a20207d0a5d0a"}]}"#.to_string())], datums);
+        assert_eq!(
+            vec![TxDatum(
+                format!(
+                    r#"{{"constructor":0,"fields":[{{"bytes":"{}"}}]}}"#,
+                    test_cli_runner_values::LAUNCH_UTXO_EXPECTED_BYTES
+                )
+                .to_string()
+            )],
+            datums
+        );
     }
 
     #[tokio::test]
@@ -665,13 +680,19 @@ mod tests {
             .get_current_stake_value("pool1qqyjr9pcrv97gwrueunug829fs5znw6p2wxft3fvqkgu5f4qlrg")
             .await
             .expect("get current stake value should not fail");
-        assert_eq!(3_000_000, stake);
+        assert_eq!(
+            test_cli_runner_values::LAUNCH_STAKE_SNAPSHOT_EXPECTED_DEFAULT_POOL_STAKE_MARK,
+            stake
+        );
 
         let stake = observer
-            .get_current_stake_value("pool1qpqvz90w7qsex2al2ejjej0rfgrwsguch307w8fraw7a7adf6g8")
+            .get_current_stake_value(test_cli_runner_values::LAUNCH_STAKE_SNAPSHOT_POOL_ID_SPECIFIC)
             .await
             .expect("get current stake value should not fail");
-        assert_eq!(0, stake);
+        assert_eq!(
+            test_cli_runner_values::LAUNCH_STAKE_SNAPSHOT_EXPECTED_POOL_STAKE_MARK_FOR_POOL_ID_SPECIFIC,
+            stake
+        );
     }
 
     #[tokio::test]
@@ -709,15 +730,15 @@ mod tests {
         let mut expected_stake_distribution = StakeDistribution::new();
         expected_stake_distribution.insert(
             "pool1qqqqqdk4zhsjuxxd8jyvwncf5eucfskz0xjjj64fdmlgj735lr9".to_string(),
-            300000000001,
+            test_cli_runner_values::LAUNCH_STAKE_SNAPSHOT_ALL_POOLS_EXPECTED_STAKE_MARK_POOL_1,
         );
         expected_stake_distribution.insert(
             "pool1qqqqpanw9zc0rzh0yp247nzf2s35uvnsm7aaesfl2nnejaev0uc".to_string(),
-            600000000001,
+            test_cli_runner_values::LAUNCH_STAKE_SNAPSHOT_ALL_POOLS_EXPECTED_STAKE_MARK_POOL_2,
         );
         expected_stake_distribution.insert(
             "pool1qqqqzyqf8mlm70883zht60n4q6uqxg4a8x266sewv8ad2grkztl".to_string(),
-            1200000000001,
+            test_cli_runner_values::LAUNCH_STAKE_SNAPSHOT_ALL_POOLS_EXPECTED_STAKE_MARK_POOL_3,
         );
         assert_eq!(
             BTreeMap::from_iter(
@@ -806,6 +827,9 @@ mod tests {
             .await
             .unwrap()
             .unwrap();
-        assert_eq!(404, kes_period);
+        assert_eq!(
+            test_cli_runner_values::LAUNCH_KES_PERIOD_EXPECTED_KES_PERIOD,
+            kes_period
+        );
     }
 }