feat(client-lib+client-wasm): certificate verifier cache duration can now be set at the client level

With a default duration of one week

Author: Alenar

mithril-client-wasm/src/client_wasm.rs

@@ -91,17 +91,20 @@ impl MithrilClient {
                 .map_err(|err| format!("Failed to parse options: {err:?}"))
                 .unwrap()
         };
-        let unstable = client_options.unstable;
-        let enable_certificate_chain_verification_cache =
-            client_options.enable_certificate_chain_verification_cache;
         let mut client_builder =
             ClientBuilder::aggregator(aggregator_endpoint, genesis_verification_key)
                 .add_feedback_receiver(feedback_receiver)
-                .with_options(client_options);
+                .with_options(client_options.clone());
 
-        let certificate_verifier_cache = if unstable && enable_certificate_chain_verification_cache
+        let certificate_verifier_cache = if client_options.unstable
+            && client_options.enable_certificate_chain_verification_cache
         {
-            let cache = Self::build_certifier_cache(aggregator_endpoint, TimeDelta::weeks(1));
+            let cache = Self::build_certifier_cache(
+                aggregator_endpoint,
+                TimeDelta::seconds(
+                    client_options.certificate_chain_verification_cache_duration_in_seconds as i64,
+                ),
+            );
             if let Some(cache) = &cache {
                 client_builder = client_builder.with_certificate_verifier_cache(cache.clone());
             }
@@ -118,7 +121,7 @@ impl MithrilClient {
         MithrilClient {
             client,
             certificate_verifier_cache,
-            unstable,
+            unstable: client_options.unstable,
         }
     }
 
@@ -461,7 +464,7 @@ mod tests {
 
     const GENESIS_VERIFICATION_KEY: &str = "5b33322c3235332c3138362c3230312c3137372c31312c3131372c3133352c3138372c3136372c3138312c3138382c32322c35392c3230362c3130352c3233312c3135302c3231352c33302c37382c3231322c37362c31362c3235322c3138302c37322c3133342c3133372c3234372c3136312c36385d";
     const FAKE_AGGREGATOR_IP: &str = "127.0.0.1";
-    const FAKE_AGGREGATOR_PORT: &str = "8000";
+    const FAKE_AGGREGATOR_PORT: &str = "8001";
 
     fn get_mithril_client(options: ClientOptions) -> MithrilClient {
         let options_js_value = serde_wasm_bindgen::to_value(&options).unwrap();

mithril-client/src/client.rs

@@ -22,8 +22,13 @@ use crate::snapshot_client::SnapshotClient;
 use crate::snapshot_downloader::{HttpSnapshotDownloader, SnapshotDownloader};
 use crate::MithrilResult;
 
+#[cfg(target_family = "wasm")]
+const fn certificate_chain_verification_cache_duration_in_seconds_default() -> u32 {
+    604800
+}
+
 /// Options that can be used to configure the client.
-#[derive(Debug, Default, Serialize, Deserialize)]
+#[derive(Debug, Clone, Default, Serialize, Deserialize)]
 pub struct ClientOptions {
     /// HTTP headers to include in the client requests.
     pub http_headers: Option<HashMap<String, String>>,
@@ -42,6 +47,19 @@ pub struct ClientOptions {
     #[cfg(target_family = "wasm")]
     #[cfg_attr(target_family = "wasm", serde(default))]
     pub enable_certificate_chain_verification_cache: bool,
+
+    /// Duration in seconds of certificate chain verification cache in the WASM client.
+    ///
+    /// Default to one week (604800 seconds).
+    ///
+    /// `enable_certificate_chain_verification_cache` and `unstable` must both be set to `true`
+    /// for this option to have any effect.
+    #[cfg(target_family = "wasm")]
+    #[cfg_attr(
+        target_family = "wasm",
+        serde(default = "certificate_chain_verification_cache_duration_in_seconds_default")
+    )]
+    pub certificate_chain_verification_cache_duration_in_seconds: u32,
 }
 
 impl ClientOptions {
@@ -53,6 +71,9 @@ impl ClientOptions {
             unstable: false,
             #[cfg(target_family = "wasm")]
             enable_certificate_chain_verification_cache: false,
+            #[cfg(target_family = "wasm")]
+            certificate_chain_verification_cache_duration_in_seconds:
+                certificate_chain_verification_cache_duration_in_seconds_default(),
         }
     }