[WIP] refactor: secure and simplify /ledger and /volatile directories handling in DummyImmutablesDbBuilder

Author: dlachaume

mithril-common/src/digesters/dummy_immutable_db_builder.rs

@@ -6,6 +6,10 @@ use std::{
     path::{Path, PathBuf},
 };
 
+const IMMUTABLE_DIR: &str = "immutable";
+const LEDGER_DIR: &str = "ledger";
+const VOLATILE_DIR: &str = "volatile";
+
 /// A [DummyImmutableDb] builder.
 pub struct DummyImmutablesDbBuilder {
     dir: PathBuf,
@@ -146,20 +150,20 @@ impl DummyImmutablesDbBuilder {
             ));
         }
 
-        if !self.ledger_files_to_write.is_empty() {
-            let ledger_dir = self.dir.parent().unwrap().join("ledger");
-            std::fs::create_dir_all(&ledger_dir).unwrap();
-            for filename in &self.ledger_files_to_write {
-                write_dummy_file(self.ledger_file_size, &ledger_dir, filename);
-            }
-        };
-
-        if !self.volatile_files_to_write.is_empty() {
-            let volatile_dir = self.dir.parent().unwrap().join("volatile");
-            std::fs::create_dir_all(&volatile_dir).unwrap();
-            for filename in &self.volatile_files_to_write {
-                write_dummy_file(self.volatile_file_size, &volatile_dir, filename);
-            }
+        for filename in &self.ledger_files_to_write {
+            write_dummy_file(
+                self.ledger_file_size,
+                &self.dir.parent().unwrap().join(LEDGER_DIR),
+                filename,
+            );
+        }
+
+        for filename in &self.volatile_files_to_write {
+            write_dummy_file(
+                self.volatile_file_size,
+                &self.dir.parent().unwrap().join(VOLATILE_DIR),
+                filename,
+            );
         }
 
         DummyImmutableDb {
@@ -173,7 +177,10 @@ impl DummyImmutablesDbBuilder {
     }
 
     fn get_test_dir(subdir_name: &str) -> PathBuf {
-        TempDir::create(subdir_name, "immutable")
+        TempDir::create(subdir_name, LEDGER_DIR);
+        TempDir::create(subdir_name, VOLATILE_DIR);
+
+        TempDir::create(subdir_name, IMMUTABLE_DIR)
     }
 }