refactor(relay): move huge context data away from logs main msg

And instead add them to a property. This allow to keep the main log
messages leans while still providing detailed errors info.

Author: Alenar

mithril-relay/src/relay/aggregator.rs

@@ -53,10 +53,10 @@ impl AggregatorRelay {
             },
             Err(err) => {
                 error!(
-                    self.logger,
-                    "Relay aggregator: Post `/register-signatures` failed: {err:?}"
+                    self.logger, "Relay aggregator: Post `/register-signatures` failed";
+                    "error" => ?err
                 );
-                Err(anyhow!("Post `/register-signatures` failed: {err:?}"))
+                Err(anyhow!(err).context("Post `/register-signatures` failed"))
             }
         }
     }
@@ -84,10 +84,10 @@ impl AggregatorRelay {
             },
             Err(err) => {
                 error!(
-                    self.logger,
-                    "Relay aggregator: Post `/register-signer` failed: {err:?}"
+                    self.logger, "Relay aggregator: Post `/register-signer` failed";
+                    "error" => ?err
                 );
-                Err(anyhow!("Post `/register-signer` failed: {err:?}"))
+                Err(anyhow!(err).context("Post `/register-signer` failed"))
             }
         }
     }

mithril-relay/src/relay/signer.rs

@@ -306,26 +306,23 @@ mod handlers {
                         Ok(Box::new(warp::reply::with_status(content, status)))
                     }
                     Err(err) => {
-                        debug!(logger, "SignerRelay: received error '{err:?}'");
+                        debug!(logger, "SignerRelay: received error"; "error" => ?err);
                         Ok(Box::new(warp::reply::with_status(
                             format!("{err:?}"),
                             StatusCode::INTERNAL_SERVER_ERROR,
                         )))
                     }
                 },
                 Err(err) => {
-                    debug!(
-                        logger,
-                        "SignerRelay: failed to parse the returned status '{err:?}'"
-                    );
+                    debug!(logger, "SignerRelay: failed to parse the returned status"; "error" => ?err);
                     Ok(Box::new(warp::reply::with_status(
                         format!("{err:?}"),
                         StatusCode::INTERNAL_SERVER_ERROR,
                     )))
                 }
             },
             Err(err) => {
-                debug!(logger, "SignerRelay: received error '{err:?}'");
+                debug!(logger, "SignerRelay: received error"; "error" => ?err);
                 Ok(Box::new(warp::reply::with_status(
                     format!("{err:?}"),
                     StatusCode::INTERNAL_SERVER_ERROR,

mithril-relay/tests/register_signer_signature.rs

@@ -140,15 +140,15 @@ async fn should_receive_registrations_from_signers_when_subscribed_to_pubsub() {
             event =  p2p_client1.tick_peer() => {
                 if let Ok(Some(BroadcastMessage::RegisterSigner(signer_message_received))) = p2p_client1.convert_peer_event_to_message(event.unwrap().unwrap())
                 {
-                    info!("Test: client1 consumed signer registration: {signer_message_received:#?}");
+                    info!("Test: client1 consumed signer registration"; "message" => #?signer_message_received);
                     assert_eq!(signer_message_sent, signer_message_received);
                     total_peers_has_received_message += 1
                 }
             }
             event =  p2p_client2.tick_peer() => {
                 if let Ok(Some(BroadcastMessage::RegisterSigner(signer_message_received))) = p2p_client2.convert_peer_event_to_message(event.unwrap().unwrap())
                 {
-                    info!("Test: client2 consumed signer registration: {signer_message_received:#?}");
+                    info!("Test: client2 consumed signer registration"; "message" => #?signer_message_received);
                     assert_eq!(signer_message_sent, signer_message_received);
                     total_peers_has_received_message += 1
                 }
@@ -185,15 +185,15 @@ async fn should_receive_registrations_from_signers_when_subscribed_to_pubsub() {
             event =  p2p_client1.tick_peer() => {
                 if let Ok(Some(BroadcastMessage::RegisterSignature(signature_message_received))) = p2p_client1.convert_peer_event_to_message(event.unwrap().unwrap())
                 {
-                    info!("Test: client1 consumed signature: {signature_message_received:#?}");
+                    info!("Test: client1 consumed signature"; "message" => #?signature_message_received);
                     assert_eq!(signature_message_sent, signature_message_received);
                     total_peers_has_received_message += 1
                 }
             }
             event =  p2p_client2.tick_peer() => {
                 if let Ok(Some(BroadcastMessage::RegisterSignature(signature_message_received))) = p2p_client2.convert_peer_event_to_message(event.unwrap().unwrap())
                 {
-                    info!("Test: client2 consumed signature: {signature_message_received:#?}");
+                    info!("Test: client2 consumed signature"; "message" => #?signature_message_received);
                     assert_eq!(signature_message_sent, signature_message_received);
                     total_peers_has_received_message += 1
                 }