Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-302] Add acceptance tests for maximum wallets limit #979

Conversation

thedanheller
Copy link
Contributor

@thedanheller thedanheller commented Jun 15, 2018

This PR adds acceptance tests for maximum wallets limit.

Todo:

  • Create 20 wallets and checks if all of them are visible in the UI
  • Check if the buttons in the "Add wallet" screen are disabled
  • When deleting a wallet, the buttons should get enabled

Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (npm run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (npm run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (npm run package / CI builds)
  • There are no flow errors or warnings (npm run flow:test)
  • There are no lint errors or warnings (npm run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running npm run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (npm run storybook)
  • In case of npm dependency changes both package-lock.json and yarn.lock files are updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@thedanheller thedanheller removed the WIP label Jun 15, 2018
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, please just refactor the second scenario to be more focused on the goal of this test 😉

In general it's important to avoid unnecessary ceremony in test cases as much as possible

And I enter "Wallet 20" as name of the wallet to confirm
And I submit the delete wallet dialog
And I click on the add wallet button in the sidebar
Then The buttons in the Add Wallet screen should be enabled
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this test is not really about "deleting a wallet" i would like the deletion to be shortened to a single step like this:

Scenario: User deletes one wallet and re-enable its Adding new wallets
  Given I create wallets until I reach the maximum number permitted
  When I delete the last wallet
  Then The buttons in the Add Wallet screen should be enabled

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DominikGuzei sure! I've done this way to re-use existing steps. I'll create a unified one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DominikGuzei DominikGuzei merged commit 4b6957f into develop Jun 20, 2018
@DominikGuzei DominikGuzei deleted the chore/ddw-302-add-acceptance-tests-for-maximum-wallets-limit branch June 20, 2018 13:12
This was referenced Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants