-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-302] Add acceptance tests for maximum wallets limit #979
[DDW-302] Add acceptance tests for maximum wallets limit #979
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, please just refactor the second scenario to be more focused on the goal of this test 😉
In general it's important to avoid unnecessary ceremony in test cases as much as possible
features/wallets-limit.feature
Outdated
And I enter "Wallet 20" as name of the wallet to confirm | ||
And I submit the delete wallet dialog | ||
And I click on the add wallet button in the sidebar | ||
Then The buttons in the Add Wallet screen should be enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this test is not really about "deleting a wallet" i would like the deletion to be shortened to a single step like this:
Scenario: User deletes one wallet and re-enable its Adding new wallets
Given I create wallets until I reach the maximum number permitted
When I delete the last wallet
Then The buttons in the Add Wallet screen should be enabled
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@DominikGuzei sure! I've done this way to re-use existing steps. I'll create a unified one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✓
This PR adds acceptance tests for maximum wallets limit.
Todo:
Review Checklist:
Basics
npm run test
)npm run dev
)npm run package
/ CI builds)npm run flow:test
)npm run lint
)npm run manage:translations
produces no changes)npm run storybook
)package-lock.json
andyarn.lock
files are updatedCode Quality
Testing
After Review:
done
on the Youtrack board