-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-433] Expose Cardano Node states to the UI #1118
Merged
nikolaglumac
merged 23 commits into
develop
from
feature/ddw-433-expose-cardano-node-states-to-the-ui
Oct 16, 2018
Merged
[DDW-433] Expose Cardano Node states to the UI #1118
nikolaglumac
merged 23 commits into
develop
from
feature/ddw-433-expose-cardano-node-states-to-the-ui
Oct 16, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[DEVOPS-998] [CO-354] Update cardano-sl to PR branch
@darko-mijic can you please proof-read the new messages? Please see PR description... Thanks! |
@DominikGuzei this PR is ready for review. I have left the |
DominikGuzei
previously approved these changes
Oct 15, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's perfect now! 👍 ready to be merged when translations are done
DominikGuzei
previously approved these changes
Oct 16, 2018
deepfire
approved these changes
Oct 16, 2018
nikolaglumac
deleted the
feature/ddw-433-expose-cardano-node-states-to-the-ui
branch
October 16, 2018 12:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes Cardano Node states on the Loading screen.
The states include:
starting
,stopping
,stopped
,updating
,updated
,crashed
andunrecoverable
.In case of the
unrecoverable
state we automatically show the "Having trouble connecting?" notification.In the scope of this PR the following changes are also added:
package.json
and inCHANGELOG
to0.12.0
release/0.11.1
branch which fixesdevelop->master
merge conflicts withincardano-sl-src.json
fileTodo:
Screenshots
Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board