Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-433] Expose Cardano Node states to the UI #1118

Merged

Conversation

nikolaglumac
Copy link
Contributor

@nikolaglumac nikolaglumac commented Oct 11, 2018

This PR exposes Cardano Node states on the Loading screen.
The states include: starting, stopping, stopped, updating, updated, crashed and unrecoverable.
In case of the unrecoverable state we automatically show the "Having trouble connecting?" notification.

In the scope of this PR the following changes are also added:

  • Bump of Daedalus version in package.json and in CHANGELOG to 0.12.0
  • Merge of release/0.11.1 branch which fixes develop->master merge conflicts within cardano-sl-src.json file

Todo:

  • Inject missing Japanese translations:
"loading.screen.crashedCardanoMessage": "Cardano node crashed",
"loading.screen.startingCardanoMessage": "Starting Cardano node",
"loading.screen.stoppedCardanoMessage": "Cardano node stopped",
"loading.screen.stoppingCardanoMessage": "Stopping Cardano node",
"loading.screen.updatedCardanoMessage": "Cardano node updated",
"loading.screen.updatingCardanoMessage": "Updating Cardano node",
"loading.screen.unrecoverableCardanoMessage": "Unable to start Cardano node. Please submit a support request.",

Screenshots

screen shot 2018-10-15 at 13 40 22

version-bump

version-bump-2


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@nikolaglumac
Copy link
Contributor Author

@darko-mijic can you please proof-read the new messages? Please see PR description... Thanks!

@nikolaglumac
Copy link
Contributor Author

@DominikGuzei this PR is ready for review. I have left the WIP tag only because we have missing translations...

DominikGuzei
DominikGuzei previously approved these changes Oct 15, 2018
Copy link
Member

@DominikGuzei DominikGuzei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's perfect now! 👍 ready to be merged when translations are done

@DominikGuzei DominikGuzei self-requested a review October 16, 2018 08:40
DominikGuzei
DominikGuzei previously approved these changes Oct 16, 2018
@nikolaglumac nikolaglumac removed the WIP label Oct 16, 2018
@nikolaglumac nikolaglumac requested a review from deepfire October 16, 2018 12:18
@nikolaglumac nikolaglumac merged commit e7c5d3a into develop Oct 16, 2018
@nikolaglumac nikolaglumac deleted the feature/ddw-433-expose-cardano-node-states-to-the-ui branch October 16, 2018 12:19
This was referenced Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants