-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-427] Handle new transaction fee calculation error messages #1111
Merged
DominikGuzei
merged 14 commits into
develop
from
fix/ddw-427-handle-new-transaction-fee-calculation-errors
Oct 10, 2018
Merged
[DDW-427] Handle new transaction fee calculation error messages #1111
DominikGuzei
merged 14 commits into
develop
from
fix/ddw-427-handle-new-transaction-fee-calculation-errors
Oct 10, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
previously approved these changes
Oct 8, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
nikolaglumac
requested review from
darko-mijic,
MarcusHurney and
DominikGuzei
October 10, 2018 07:30
DominikGuzei
approved these changes
Oct 10, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
DominikGuzei
deleted the
fix/ddw-427-handle-new-transaction-fee-calculation-errors
branch
October 10, 2018 09:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces more granular error messages for transaction-fee-calculation Api endpoint:
Todo:
cardano-sl-src.json
to the commit which contains the fixed Api error response ([CBR-464] Raise CorrectCoinSelHardErr
during coin selection cardano-sl#3710)Screenshots:
Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board