-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-421] Record screenshots of failed acceptance tests #1103
[DDW-421] Record screenshots of failed acceptance tests #1103
Conversation
…led-acceptance-tests
features/support/electron.js
Outdated
@@ -17,6 +21,24 @@ const printMainProcessLogs = () => ( | |||
}) | |||
); | |||
|
|||
const getFile = (testName) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename this to generateFilePath
since that's what's happening 😉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅
@nikolaglumac @DominikGuzei I've moved the screenshot method into a separated file, so it can be imported and used in different contexts, e.g. to see how the screen looks a step before the error happens. Could you please review it again. |
Great refactoring @daniloprates, that looks perfect now! 🎉 |
@DominikGuzei I promise it's the last change. I've added a step called |
…led-acceptance-tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 🎉
This PR adds screenshots record of failed acceptance tests.
Screenshots:
Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board