Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-400] Dynamic Api port #1067

Merged
merged 4 commits into from
Aug 30, 2018
Merged

Conversation

DominikGuzei
Copy link
Member

This PR makes the ada api configurable which is a requirement for the upcoming features for controlling the backend node from within Daedalus (hence having to dynamically change port / certs while running).

The general idea is to move any configurable values out of the api class and pass it in as params / provide a config setter to update the values during runtime. Another benefit of this refactoring is the separation of config params (e.g: port / ca) vs. request params for the specific api call … which makes more sense than to include ca in all request types.


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@nikolaglumac nikolaglumac changed the title Chore/ddw 400 dynamic api port [DDW-400] Dynamic Api port Aug 29, 2018
@nikolaglumac
Copy link
Contributor

Reviewing this one now...

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work @DominikGuzei 🎉
Ready to merge once CI is done...

@nikolaglumac nikolaglumac merged commit 38f86fe into develop Aug 30, 2018
@nikolaglumac nikolaglumac deleted the chore/ddw-400-dynamic-api-port branch August 30, 2018 11:13
This was referenced Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants