-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-359] V1 API endpoints integration 5/5 #1045
Merged
MarcusHurney
merged 13 commits into
feature/ddw-321-v1-api-integration
from
feature/ddw-359-v1-api-endpoints-integration-5-5
Aug 30, 2018
Merged
[DDW-359] V1 API endpoints integration 5/5 #1045
MarcusHurney
merged 13 commits into
feature/ddw-321-v1-api-integration
from
feature/ddw-359-v1-api-endpoints-integration-5-5
Aug 30, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusHurney
changed the base branch from
develop
to
feature/ddw-321-v1-api-integration
August 22, 2018 00:04
thedanheller
suggested changes
Aug 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a conflict to be resolved
…thub.com:input-output-hk/daedalus into feature/ddw-359-v1-api-endpoints-integration-5-5 Pulls latest from feature/ddw-321
nikolaglumac
deleted the
feature/ddw-359-v1-api-endpoints-integration-5-5
branch
October 1, 2018 12:19
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the depreciated requests getAdaSyncProgress.js and getAdaLocalTimeDifference.js with a new request called getNodeInfo.js that uses a common endpoint for both cases.
Updates the AdaApi methods getLocalTimeDifference and getSyncProgress to use V1 specs.
Updates NetworkStatusStore.js to use V1 specs and the updated AdaApi methods above.
Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board