Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-359] V1 API endpoints integration 5/5 #1045

Conversation

MarcusHurney
Copy link
Contributor

@MarcusHurney MarcusHurney commented Aug 14, 2018

  • This PR replaces the depreciated requests getAdaSyncProgress.js and getAdaLocalTimeDifference.js with a new request called getNodeInfo.js that uses a common endpoint for both cases.

  • Updates the AdaApi methods getLocalTimeDifference and getSyncProgress to use V1 specs.

  • Updates NetworkStatusStore.js to use V1 specs and the updated AdaApi methods above.

Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@MarcusHurney MarcusHurney self-assigned this Aug 14, 2018
@MarcusHurney MarcusHurney changed the base branch from develop to feature/ddw-321-v1-api-integration August 22, 2018 00:04
@thedanheller thedanheller self-requested a review August 28, 2018 14:16
Copy link
Contributor

@thedanheller thedanheller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a conflict to be resolved

@MarcusHurney MarcusHurney merged commit 6ae58fe into feature/ddw-321-v1-api-integration Aug 30, 2018
@nikolaglumac nikolaglumac deleted the feature/ddw-359-v1-api-endpoints-integration-5-5 branch October 1, 2018 12:19
This was referenced Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants