Parameterize Address Format #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
commented
May 3, 2019
| @@ -66,6 +66,7 @@ library | |||
| exposed-modules: | |||
| Cardano.Environment | |||
| Cardano.Wallet | |||
| Cardano.Wallet.Compatibility | |||
There was a problem hiding this comment.
This is temporary, once all the necessary refactored are completed, I'll create a new package lib/http-bridge which will contain all the Byron http-bridge-specific code, leaving lib/core completely agnostic to the network binary format and state being used.
akegalj
approved these changes
May 3, 2019
parsonsmatt
added a commit
to parsonsmatt/cardano-sl
that referenced
this pull request
May 14, 2019
3995: Special case 404 errors with empty bodies r=KtorZ a=parsonsmatt ## Description The PR adding `nextUpdate` testing to the cardano-wallet repo ([here](cardano-foundation/cardano-wallet#210)) demonstrated a bug in the way the Node client was handling 404 errors. As these typically don't have response bodies, it was failing them in a way that was really awkward to check. This PR provides a special case that should make the program work better. ## Linked issue <!--- Put here the relevant issue from YouTrack --> Co-authored-by: parsonsmatt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
Overview
Comments