Fix benchmarks in Buildkite #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that stack doesn't eat them.
KtorZ
reviewed
Apr 10, 2019
| -- Failure response (e.g. 404 /mainnet/tip). | ||
| -- This can be recovered from by retrying the request. | ||
| Left e@(FailureResponse _) -> | ||
| return $ Left $ ErrNetworkUnreachable $ T.pack $ displayException e |
There was a problem hiding this comment.
This shouldn't be in the default handler because the semantic we give to 404 is different depending on the endpoint. Actually, 404 are already handled for epochs for instance. If this is needed for the /networkTip endpoint, let's add it to the getNetworkTip handler, like done for getEpoch
There was a problem hiding this comment.
OK, moved. I tried both
getNetworkTip :: ExceptT ErrNetworkUnreachable m (Maybe (Hash "BlockHeader", BlockHeader))
-- and
getNetworkTip :: ExceptT ErrNetworkTip m (Hash "BlockHeader", BlockHeader)The latter seems better.
rvl
force-pushed
the
rvl/100/buildkite-nightly
branch
from
8236d1e to
6576e43
Compare
KtorZ
approved these changes
Apr 11, 2019
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #100
Overview
The builds are here: https://buildkite.com/input-output-hk/cardano-wallet-nightly