Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network.hs listen test slightly improving test coverage #153

Merged
merged 1 commit into from
Apr 4, 2019

Conversation

piotr-iohk
Copy link
Contributor

Issue Number

Overview

  • I have added Network.hs listen test slightly improving test coverage

Comments

@piotr-iohk piotr-iohk self-assigned this Apr 4, 2019
@piotr-iohk piotr-iohk requested a review from KtorZ April 4, 2019 14:44
@@ -140,6 +146,10 @@ spec = do
(show err) `shouldContain`
"Transaction failed verification: transaction has more witnesses than inputs"
where
actionDummy :: [Block] -> IO ()
actionDummy b = do
putStr (show b)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were so many possibilities. So many things you could do with this Block. And you choose to print it!

I am so disappointed :trollface:

Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (will merge after #140)

@KtorZ KtorZ force-pushed the piotr/more_tests branch from 301f480 to 73c6e64 Compare April 4, 2019 15:56
@KtorZ KtorZ merged commit 4e7a912 into master Apr 4, 2019
@KtorZ KtorZ deleted the piotr/more_tests branch April 4, 2019 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants