-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Haskell variables for passing values. #5011
Conversation
This is a stripped down version of #4845. |
9415a46
to
44a02bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nice improvement in terms of size of the PR. I left a few comments that need to be address. In future, do not include function definitions that are not in used in the PR.
Use the wrapper functions in the Shelley testnet.
4b824c7
to
bc210d5
Compare
Currently the
cardano-testnet
uses filenames (Strings) to reference objects like keys, certs etc.Two locations in the code refer to the same object by using the same filename.
This means that the data flow is implicit and hard to follow.
Old scheme:
This PR changes the design as follows:
File
datatype (which wraps the file path).File
resource.IO ()
the wrapper has type `IO (File,..,File).File
resource that was created earlier.The new scheme is
Full transformation to the new scheme for filenames is still WIP.