Implement Cardano.Api.DeserialiseAnyOf #4639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jimbo4350
force-pushed
the
jordan/create-deserialise-any-of
branch
2 times, most recently
from
4fd4eee to
d744c0c
Compare
Jimbo4350
requested review from
dcoutts,
erikd,
newhoggy,
JaredCorduan,
LudvikGalois and
CarlosLopezDeLara
as code owners
Comment on lines
+261
to
+263
| renderSomeAddressVerificationKey (AGenesisDelegateExtendedVerificationKey vk) = | ||
| -- TODO: We could implement a CastVerificationKeyRole GenesisDelegateKey PaymentKey | ||
| -- if we want to avoid casting twice. | ||
| let genDelegKey = (castVerificationKey vk :: VerificationKey GenesisDelegateKey) | ||
| stakePoolKey = castVerificationKey genDelegKey :: VerificationKey StakePoolKey | ||
| in serialiseToBech32 stakePoolKey |
There was a problem hiding this comment.
Has the comment become outdated? I don't think you want CastVerificationKeyRole GenesisDelegateKey PaymentKey. It looks to me like you want CastVerificationKeyRole GenesisKey PaymentKey and CastVerificationKeyRole GenesisDelegateKey StatePoolKey
There was a problem hiding this comment.
They all use the same crypto. I could also implement a SerialiseAsBech32 (VerificationKey GenesisDelegateKey) instance as another option.
LudvikGalois
approved these changes
Nov 17, 2022
Jimbo4350
force-pushed
the
jordan/create-deserialise-any-of
branch
from
d744c0c to
031e0d5
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move verification key related serialization to
cardano-apiand expose a simpler interface.