Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update building-the-node-using-nix.md #4613

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Update building-the-node-using-nix.md #4613

merged 1 commit into from
Nov 8, 2022

Conversation

CarlosLopezDeLara
Copy link
Contributor

Build the cardano-node executable. No default configuration.

@CarlosLopezDeLara CarlosLopezDeLara requested a review from a team as a code owner November 4, 2022 07:24
deepfire
deepfire reviewed Nov 4, 2022
View reviewed changes
doc/getting-started/building-the-node-using-nix.md Outdated
@@ -44,6 +44,10 @@ or run in in one go:
nix run github:input-output-hk/cardano-node#mainnet/node
```

To build the cardano-node executable:
Copy link
Contributor

@deepfire deepfire Nov 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would have reworded this to underscore the difference -- something like:

If you only want to build just the cardano-node executable, without the configuration bundle:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And it doesn't help that line 35 above doesn't really explain what it achieves.

We could reword it too, from:

Once Nix is installed, log out and then log back in.

After that you can build the full node package with Mainnet configuration as follows:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amended the commit with your suggestions, thanks Serge!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There goes another amendment! =)

@CarlosLopezDeLara CarlosLopezDeLara force-pushed the build-nix-doc branch 3 times, most recently from 2a8ded4 to bfbfd82 Compare November 4, 2022 07:58
disassembler
disassembler requested changes Nov 4, 2022
View reviewed changes
doc/getting-started/building-the-node-using-nix.md
@@ -24,15 +24,16 @@ To improve build speed, it is possible to set up a binary cache maintained by IO
optional**):
```
sudo mkdir -p /etc/nix
cat <<EOF | sudo tee /etc/nix/nix.conf
cat <<EOF | sudo tee -a /etc/nix/nix.conf
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the caches in this file?;we no longer use iohk.cachix.org. and the substituter should be cache.iog.io now (but the key still has hydra in the name)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think I understood correctly. I updated the commit.

@CarlosLopezDeLara CarlosLopezDeLara linked an issue Nov 4, 2022 that may be closed by this pull request
[BUG] - Can't build standalone cardano-node with Nix #3980
Closed
@CarlosLopezDeLara
Update building-the-node-using-nix.md
5cd94d3 
Build the cardano-node executable. No default configuration.
@disassembler
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Nov 7, 2022
@iohk-bors @CarlosLopezDeLara
Merge #4613
96eb6ba 
4613: Update building-the-node-using-nix.md r=disassembler a=CarlosLopezDeLara

Build the cardano-node executable. No default configuration.

Co-authored-by: CarlosLopezDeLara <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 7, 2022

Timed out.

@CarlosLopezDeLara
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Nov 8, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit fc991bf into master Nov 8, 2022
@iohk-bors iohk-bors bot deleted the build-nix-doc branch November 8, 2022 13:42
@newhoggy newhoggy mentioned this pull request Mar 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepfire deepfire deepfire left review comments

@disassembler disassembler disassembler approved these changes

@olgahryniuk olgahryniuk olgahryniuk approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - Can't build standalone cardano-node with Nix
5 participants
@CarlosLopezDeLara @disassembler @deepfire @nalane @olgahryniuk