Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimise config #4351

Merged
merged 33 commits into from
Sep 21, 2022
Merged

Minimise config #4351

merged 33 commits into from
Sep 21, 2022

Conversation

jutaro
Copy link
Contributor

@jutaro jutaro commented Aug 17, 2022

Minimise the default tracer file config, by adding a hardcoded default tracer config. The config loaded from the file can then overwrite all values set by defaults. This pull requests then includes some adoptions to config files. As well some fixes for metrics are included in this pull request.

@jutaro jutaro self-assigned this Aug 17, 2022
@jutaro jutaro linked an issue Aug 17, 2022 that may be closed by this pull request
@deepfire deepfire force-pushed the jutaro/minimise-config branch from 9428b67 to 0f514fa Compare August 19, 2022 18:06
@jutaro jutaro force-pushed the jutaro/minimise-config branch from 5590e30 to fbaa1b9 Compare August 22, 2022 11:58
@deepfire deepfire force-pushed the jutaro/minimise-config branch 2 times, most recently from b47aa40 to ff71768 Compare August 23, 2022 08:35
@deepfire deepfire requested a review from fmaste as a code owner August 23, 2022 08:35
@jutaro jutaro force-pushed the jutaro/minimise-config branch from ff71768 to 2301295 Compare August 23, 2022 15:07
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @jutaro !

Now we need to benchmark this.

@deepfire deepfire force-pushed the jutaro/minimise-config branch from 2301295 to 5521973 Compare August 24, 2022 15:09
@deepfire deepfire force-pushed the jutaro/minimise-config branch from 5521973 to c19bcb1 Compare August 24, 2022 15:10
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 19, 2022

Build failed:

@deepfire deepfire force-pushed the jutaro/minimise-config branch from 991a9db to da94d39 Compare September 19, 2022 19:45
@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 19, 2022
4351: Minimise config r=deepfire a=jutaro

Minimise the default tracer file config, by adding a hardcoded default tracer config. The config loaded from the file can then overwrite all values set by defaults. This pull requests then includes some adoptions to config files. As well some fixes for metrics are included in this pull request.

Co-authored-by: Yupanqui <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 19, 2022

Build failed:

@deepfire deepfire force-pushed the jutaro/minimise-config branch from 3362522 to 15dc7a8 Compare September 19, 2022 21:26
@deepfire deepfire force-pushed the jutaro/minimise-config branch from 909bcf0 to 75e7b7d Compare September 21, 2022 17:09
@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Sep 21, 2022
4351: Minimise config r=deepfire a=jutaro

Minimise the default tracer file config, by adding a hardcoded default tracer config. The config loaded from the file can then overwrite all values set by defaults. This pull requests then includes some adoptions to config files. As well some fixes for metrics are included in this pull request.

Co-authored-by: Yupanqui <[email protected]>
Co-authored-by: Kosyrev Serge <[email protected]>
@deepfire deepfire force-pushed the jutaro/minimise-config branch from ed26eb4 to 07af13f Compare September 21, 2022 20:35
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 21, 2022

Canceled.

@deepfire
Copy link
Contributor

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Sep 21, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit ece659c into master Sep 21, 2022
@iohk-bors iohk-bors bot deleted the jutaro/minimise-config branch September 21, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tracing: minimise default config
3 participants