-
Notifications
You must be signed in to change notification settings - Fork 722
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minimise config #4351
Merged
Merged
Minimise config #4351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newhoggy
reviewed
Aug 18, 2022
newhoggy
reviewed
Aug 18, 2022
newhoggy
approved these changes
Aug 18, 2022
9428b67
to
0f514fa
Compare
5590e30
to
fbaa1b9
Compare
b47aa40
to
ff71768
Compare
ff71768
to
2301295
Compare
deepfire
approved these changes
Aug 23, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you @jutaro !
Now we need to benchmark this.
2301295
to
5521973
Compare
5521973
to
c19bcb1
Compare
Build failed: |
991a9db
to
da94d39
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 19, 2022
4351: Minimise config r=deepfire a=jutaro Minimise the default tracer file config, by adding a hardcoded default tracer config. The config loaded from the file can then overwrite all values set by defaults. This pull requests then includes some adoptions to config files. As well some fixes for metrics are included in this pull request. Co-authored-by: Yupanqui <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]>
Build failed: |
3362522
to
15dc7a8
Compare
909bcf0
to
75e7b7d
Compare
bors r+ |
iohk-bors bot
added a commit
that referenced
this pull request
Sep 21, 2022
4351: Minimise config r=deepfire a=jutaro Minimise the default tracer file config, by adding a hardcoded default tracer config. The config loaded from the file can then overwrite all values set by defaults. This pull requests then includes some adoptions to config files. As well some fixes for metrics are included in this pull request. Co-authored-by: Yupanqui <[email protected]> Co-authored-by: Kosyrev Serge <[email protected]>
ed26eb4
to
07af13f
Compare
Canceled. |
bors r+ |
Build succeeded: |
This was referenced Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimise the default tracer file config, by adding a hardcoded default tracer config. The config loaded from the file can then overwrite all values set by defaults. This pull requests then includes some adoptions to config files. As well some fixes for metrics are included in this pull request.