Bench nix refactoring 2 #4324
Merged
Bench nix refactoring 2 #4324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmaste
force-pushed
the
bench-nix-refactoring
branch
3 times, most recently
from
2a0ee19 to
e3f460d
Compare
…rol for generator
… configuration file
…espectives subfolders
fmaste
force-pushed
the
bench-nix-refactoring
branch
from
e3f460d to
83b40a3
Compare
fmaste
force-pushed
the
bench-nix-refactoring
branch
from
83b40a3 to
45ad4c8
Compare
deepfire
approved these changes
Aug 19, 2022
|
bors merge |
iohk-bors bot
added a commit
that referenced
this pull request
Aug 19, 2022
4324: Bench nix refactoring 2 r=fmaste a=fmaste - Fix an issue where `generator` failing does not lead to a complete failure of the full cluster - Make sure all the files `node` and `tracer` need are inside their respective subfolders - Make sure all path related configurations are in a special configuration file - Remove some unused code, indent and other cleanups - Move backend specific files to the backend subfolder Co-authored-by: Kosyrev Serge <[email protected]> Co-authored-by: Federico Mastellone <[email protected]>
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"Waiting on code owner review from Jimbo4350 and/or newhoggy.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
newhoggy
approved these changes
Aug 20, 2022
|
bors merge |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generatorfailing does not lead to a complete failure of the full clusternodeandtracerneed are inside their respective subfolders