Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tx-generator cleanups #4292

Merged
merged 5 commits into from
Aug 22, 2022
Merged

tx-generator cleanups #4292

merged 5 commits into from
Aug 22, 2022

Conversation

MarcFontaine
Copy link
Contributor

@MarcFontaine MarcFontaine commented Aug 10, 2022 •
edited
Loading

  • Replace IO with Monad m => m in some types.
  • reintroduce ToUTxOList.
  • Remove legacy tx-set based FundSet. (Use type FundSet = [ Fund ] for now.)

@MarcFontaine MarcFontaine marked this pull request as ready for review August 11, 2022 12:46
@deepfire
Copy link
Contributor

bors r+

iohk-bors bot added a commit that referenced this pull request Aug 17, 2022
@iohk-bors @MarcFontaine
Merge #4292
cd49b86 
4292: tx-generator cleanups r=deepfire a=MarcFontaine

* Replace `IO` with `Monad m => m` in some types.
* reintroduce `ToUTxOList`.
* Remove legacy tx-set based `FundSet`. (Use `type FundSet = [ Fund ]` for now.)

Co-authored-by: MarcFontaine <[email protected]>
@deepfire
Copy link
Contributor

bors r-

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 17, 2022

Canceled.

@deepfire deepfire marked this pull request as draft August 17, 2022 07:44
@MarcFontaine MarcFontaine mentioned this pull request Aug 17, 2022
Closed
@MarcFontaine
Copy link
Contributor Author

ToDo:
Fix this: With ix-sets removed there needs to be a way to split funds and reuse the change.
(that is : a splitting transaction with two target wallets).

@MarcFontaine
WIP use fifo
56f5a34
@MarcFontaine
tx-generator: make good use of multiple wallets.
fa2c665 
This commit allow one to sort the outputs of a transaction
into multiple destinct wallets.
In particular it makes it possible to put change outputs and
collaterals in one wallet and the split-outputs in a other wallet.
@MarcFontaine MarcFontaine force-pushed the mafo/tx-generator-cleanup2 branch from 5401ad1 to fa2c665 Compare August 19, 2022 13:54
@MarcFontaine MarcFontaine marked this pull request as ready for review August 19, 2022 14:12
@MarcFontaine MarcFontaine self-assigned this Aug 19, 2022
@MarcFontaine
Copy link
Contributor Author

bors r+

@iohk-bors
Copy link
Contributor

iohk-bors bot commented Aug 22, 2022

Build succeeded:

@iohk-bors iohk-bors bot merged commit 8300366 into master Aug 22, 2022
@iohk-bors iohk-bors bot deleted the mafo/tx-generator-cleanup2 branch August 22, 2022 09:50
@mgmeier mgmeier mentioned this pull request Aug 26, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgmeier mgmeier mgmeier approved these changes

@Jimbo4350 Jimbo4350 Awaiting requested review from Jimbo4350

@newhoggy newhoggy Awaiting requested review from newhoggy

@deepfire deepfire Awaiting requested review from deepfire

@denisshevchenko denisshevchenko Awaiting requested review from denisshevchenko

@jutaro jutaro Awaiting requested review from jutaro

@fmaste fmaste Awaiting requested review from fmaste

@cleverca22 cleverca22 Awaiting requested review from cleverca22

Assignees

@MarcFontaine MarcFontaine

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarcFontaine @deepfire @mgmeier