RTView: history backup, MVP #4192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denisshevchenko
added
RTView
denisshevchenko
force-pushed
the
issue-4176-rtview-backup
branch
from
93ec694 to
d366557
Compare
denisshevchenko
requested review from
Jimbo4350,
newhoggy and
deepfire
as code owners
deepfire
reviewed
Jul 20, 2022
| Left _ -> return noPoints | ||
| Right rawPoints -> | ||
| case CSV.decode CSV.NoHeader rawPoints of | ||
| Left _ -> return noPoints -- Maybe file was broken... |
There was a problem hiding this comment.
Should the user be notified somehow?
deepfire
approved these changes
Jul 20, 2022
There was a problem hiding this comment.
Thank you @denisshevchenko !
Left one question as comment, and here is another one:
After restoration -- how is the "undefined" gap displayed on charts, between the last historical data and the "now"?
Is it obvious to the user?
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4176
Now RTView is able to backup historical data received from connected nodes. Previously, all historical data (which is rendering on real-time charts) was stored in the memory only, so after
cardano-tracerprocess is killed, all historical data is lost. Now RTView periodically (currently - once per 5 minutes) saves historical data in CSV-files, in a standard local directory. As a result, after restart, RTView is able to restore all historical data from the backup. It means that now the user can restartcardano-tracer(for example, to upgrade it) with no fear to lost historical data.Please note that this PR introduces backup feature as MVP. Later, it will be improved by adding: