Remove hint of "string" support for ScriptData #3775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catch-21
requested review from
DavidEichmann,
dcoutts,
Jimbo4350,
erikd,
newhoggy,
nc6 and
JaredCorduan
as code owners
catch-21
changed the title
newhoggy
requested review from
LudvikGalois and
CarlosLopezDeLara
as code owners
newhoggy
approved these changes
Mar 13, 2023
newhoggy
force-pushed
the
remove-string-scriptdata
branch
from
b9c190d to
14e2ef0
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
newhoggy
force-pushed
the
remove-string-scriptdata
branch
from
14e2ef0 to
3455d14
Compare
newhoggy
force-pushed
the
remove-string-scriptdata
branch
from
3455d14 to
ac662d8
Compare
mkoura
added a commit
to IntersectMBO/cardano-node-tests
that referenced
this pull request
Mar 17, 2023
mkoura
added a commit
to IntersectMBO/cardano-node-tests
that referenced
this pull request
Mar 17, 2023
mkoura
added a commit
to IntersectMBO/cardano-node-tests
that referenced
this pull request
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's no attempt to support string in the code. Probably a copy/paste error from tx metadata. This keeps confusing people in Discord and forums so we should remove.
Fixes https://forum.cardano.org/t/cardano-cli-script-data-file-format/89304 and #3129