[Typescript] Attribute interface is wrong (wrong property name for "name").

[Supamiu]

This issue is a d.ts problem. in parse5/index.d.ts, you have this interface :

export interface Attribute {
        key: string;
        value: string;
    }

But if you get a node and log its attributes, you have this:

{ name: 'foo', value: 'bar' }

Proof:

import * as parse5 from "parse5";
import {treeAdapters} from "parse5";
let example = "<div foo='bar'></div>";
let node = parse5.parseFragment(example);
console.log(treeAdapters.default.getAttrList(node.childNodes[0]));

then check index.d.ts to see that the interface is not the good one (property "key" should be named "name").

[RReverser]

Cool, want to send a PR?

[inikulin]

I guess this issue relates to DefinetlyTyped because we don't ship any .d.ts files.

[Supamiu]

I'll send a PR to DefinetlyTyped then, thank you for your answer @inikulin.

[RReverser]

@inikulin I think it would be nice to ship them by the way, as their new typings approach allows libraries to ship & maintain their own typings without need to update anything in the DefinitelyTyped.

[inikulin]

Makes sense. Is there any tool that generates .d.ts from jsdoc comments?

[RReverser]

Well, I know they've added jsdoc support as part of microsoft/TypeScript#4789 meta-issue which allows to detect JSDoc types as if they were native TypeScript types, but I'm not sure if there's a tool to generate definitions out of that info.

[RReverser]

Some interesting links here DefinitelyTyped/DefinitelyTyped#2103

[RReverser]

We might want to try https://github.com/fivetran/typescript-closure-tools - I suppose Closure annotations are compatible with JSDoc?

[inikulin]

Created separate issue: #125

[Supamiu]

Issue created on DefinetlyTyped: DefinitelyTyped/DefinitelyTyped#9235