Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

light-client: Do not enable lightstore-sled feature by default #976

Closed
romac opened this issue Sep 16, 2021 · 0 comments · Fixed by #977
Closed

light-client: Do not enable lightstore-sled feature by default #976

romac opened this issue Sep 16, 2021 · 0 comments · Fixed by #977
Assignees
@romac
Labels
enhancement New feature or request

Comments

@romac
Copy link
Member

romac commented Sep 16, 2021

Since Hermes does not require the persistent lightstore (backed by sled) anymore, I think we should disable the corresponding feature by default as sled is not the most lightweight dependency.

What's the definition of "done" for this issue?

When running cargo tree does not contain an entry for sled anymore.
@romac romac added the enhancement New feature or request label Sep 16, 2021
@romac romac self-assigned this Sep 16, 2021
@romac romac mentioned this issue Sep 16, 2021
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romac romac

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

light-client: Disable lightstore-sled feature by default informalsystems/tendermint-rs
1 participant
@romac